public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Arthur Schwalbenberg <arthurs578@gmail.com>
Cc: john.stultz@linaro.org, dan.carpenter@oracle.com,
	cruzjbishop@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 	Staging: Android: Fixed coding issue return parenthesis in alarm_dev.c
Date: Sat, 28 Dec 2013 09:48:57 -0800	[thread overview]
Message-ID: <20131228174857.GA15772@kroah.com> (raw)
In-Reply-To: <1388246608-11272-1-git-send-email-arthurs578@gmail.com>

On Sat, Dec 28, 2013 at 11:03:28AM -0500, Arthur Schwalbenberg wrote:
> 	This is a patch to the alarm_dev.c file that fixes up a return is not
> 	a function warning found by the checkpatch.pl tool
> 
> 	Signed-off-by: Arthur Schwalbenberg <arthurs578@gmail.com>

Why the odd indentation?

> ---
>  drivers/staging/android/alarm-dev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
> index 647694f..96b2f53 100644
> --- a/drivers/staging/android/alarm-dev.c
> +++ b/drivers/staging/android/alarm-dev.c
> @@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
>   */
>  static int is_wakeup(enum android_alarm_type type)
>  {
> -	return (type == ANDROID_ALARM_RTC_WAKEUP ||
> -		type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
> +	return type == ANDROID_ALARM_RTC_WAKEUP ||
> +	       type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
>  }

This change is already in linux-next, right?  I can't apply the same
change more than once to the tree...

greg k-h

      reply	other threads:[~2013-12-28 17:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-28 16:03 [PATCH] Staging: Android: Fixed coding issue return parenthesis in alarm_dev.c Arthur Schwalbenberg
2013-12-28 17:48 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131228174857.GA15772@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arthurs578@gmail.com \
    --cc=cruzjbishop@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox