From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Joe Xue <lgxue@hotmail.com>,
"cooloney@gmail.com" <cooloney@gmail.com>,
"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
"rob@landley.net" <rob@landley.net>,
"milo.kim@ti.com" <milo.kim@ti.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: how to represent sequence of brightnesses in /sys (was Re: [PATCH] Add the LED burst trigger)
Date: Sat, 28 Dec 2013 13:50:42 -0800 [thread overview]
Message-ID: <20131228215042.GA7048@kroah.com> (raw)
In-Reply-To: <20131228212523.GA8733@amd.pavel.ucw.cz>
On Sat, Dec 28, 2013 at 10:25:23PM +0100, Pavel Machek wrote:
> Hi!
>
> > >> Sysfs is meant to be human-readable/writable, so please use plain ASCII
> > >> numbers in strings instead.
> > >
> > > Actually, sysfs is meant to be one value per file, and it is
> >
> > Ideally, yes.
> >
> > > understood that data that are "natively blob" are just passed as
> > > blob. (I believe this qualifies).
> >
> > But it doesn't buy us much here, does it? It will make e.g. shell scripts
> > needlessly complicated.
>
> echo -ne '\012' is not that bad, and parsing array of integers from
> kernel will be an ugly piece of code.
Ick, no. What are you trying to do here? Have the kernel intrepret a
sequence of bytes to flash an LED? I thought we have frameworks in
userspace already to handle this type of thing. Please don't invent new
ways of doing stuff...
greg k-h
next prev parent reply other threads:[~2013-12-28 21:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 14:30 [PATCH] Add the LED burst trigger lgxue
2013-12-25 23:09 ` Pavel Machek
2013-12-26 1:02 ` Joe Xue
2013-12-26 14:26 ` Pavel Machek
2013-12-26 15:02 ` Joe Xue
2013-12-26 16:58 ` Joe Xue
2013-12-27 12:39 ` Rob Landley
2013-12-27 13:05 ` Pavel Machek
2013-12-27 0:31 ` Joe Xue
2013-12-27 9:57 ` Pavel Machek
2013-12-28 2:08 ` Joe Xue
2013-12-28 10:16 ` Pavel Machek
2013-12-28 13:39 ` Joe Xue
2013-12-28 19:26 ` Pavel Machek
2013-12-29 0:23 ` Joe Xue
2013-12-29 10:58 ` Pavel Machek
2013-12-28 18:51 ` Geert Uytterhoeven
2013-12-28 19:29 ` how to represent sequence of brightnesses in /sys (was Re: [PATCH] Add the LED burst trigger) Pavel Machek
2013-12-28 19:34 ` Geert Uytterhoeven
2013-12-28 21:25 ` Pavel Machek
2013-12-28 21:50 ` Greg KH [this message]
2013-12-28 23:50 ` Pavel Machek
2013-12-29 1:43 ` Greg KH
2013-12-29 11:21 ` Pavel Machek
2014-01-03 0:16 ` Bryan Wu
2014-01-06 0:37 ` Pavel Machek
2013-12-27 12:33 ` [PATCH] Add the LED burst trigger Geert Uytterhoeven
2013-12-27 11:57 ` One Thousand Gnomes
2013-12-27 12:57 ` Pavel Machek
2013-12-27 14:18 ` One Thousand Gnomes
2013-12-27 15:23 ` Pavel Machek
2013-12-27 18:13 ` One Thousand Gnomes
2013-12-27 18:34 ` Geert Uytterhoeven
2013-12-27 19:37 ` Pavel Machek
2013-12-27 22:45 ` Richard Purdie
2013-12-26 11:18 ` Geert Uytterhoeven
2013-12-30 0:15 ` Joe Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131228215042.GA7048@kroah.com \
--to=greg@kroah.com \
--cc=cooloney@gmail.com \
--cc=geert@linux-m68k.org \
--cc=lgxue@hotmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=pavel@ucw.cz \
--cc=rob@landley.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox