From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751255Ab3L1Vua (ORCPT ); Sat, 28 Dec 2013 16:50:30 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40201 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973Ab3L1Vu2 (ORCPT ); Sat, 28 Dec 2013 16:50:28 -0500 X-Sasl-enc: 2q/TTX4J0ah7yl0fF987sCVtw1fSdvt9LVbpRmM6Sgcf 1388267427 Date: Sat, 28 Dec 2013 13:50:42 -0800 From: Greg KH To: Pavel Machek Cc: Geert Uytterhoeven , Joe Xue , "cooloney@gmail.com" , "rpurdie@rpsys.net" , "rob@landley.net" , "milo.kim@ti.com" , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: how to represent sequence of brightnesses in /sys (was Re: [PATCH] Add the LED burst trigger) Message-ID: <20131228215042.GA7048@kroah.com> References: <20131226142607.GA15225@amd.pavel.ucw.cz> <20131227095705.GC17143@amd.pavel.ucw.cz> <20131228101622.GA13564@amd.pavel.ucw.cz> <20131228192935.GA28119@amd.pavel.ucw.cz> <20131228212523.GA8733@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131228212523.GA8733@amd.pavel.ucw.cz> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 28, 2013 at 10:25:23PM +0100, Pavel Machek wrote: > Hi! > > > >> Sysfs is meant to be human-readable/writable, so please use plain ASCII > > >> numbers in strings instead. > > > > > > Actually, sysfs is meant to be one value per file, and it is > > > > Ideally, yes. > > > > > understood that data that are "natively blob" are just passed as > > > blob. (I believe this qualifies). > > > > But it doesn't buy us much here, does it? It will make e.g. shell scripts > > needlessly complicated. > > echo -ne '\012' is not that bad, and parsing array of integers from > kernel will be an ugly piece of code. Ick, no. What are you trying to do here? Have the kernel intrepret a sequence of bytes to flash an LED? I thought we have frameworks in userspace already to handle this type of thing. Please don't invent new ways of doing stuff... greg k-h