* [PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix
@ 2013-12-27 22:40 Sasha Levin
2013-12-30 10:48 ` Kirill A. Shutemov
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2013-12-27 22:40 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Sasha Levin
I messed up and forgot to commit this fix before sending out the original
patch.
It fixes build issues in various files using VM_BUG_ON_PAGE.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
include/linux/mmdebug.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index e522734..8bb6490 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -2,6 +2,7 @@
#define LINUX_MM_DEBUG_H 1
#ifdef CONFIG_DEBUG_VM
+extern void dump_page(struct page *page);
#define VM_BUG_ON(cond) BUG_ON(cond)
#define VM_BUG_ON_PAGE(cond, page) \
do { if (unlikely(cond)) { dump_page(page); BUG(); } } while(0)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix
2013-12-27 22:40 [PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix Sasha Levin
@ 2013-12-30 10:48 ` Kirill A. Shutemov
0 siblings, 0 replies; 2+ messages in thread
From: Kirill A. Shutemov @ 2013-12-30 10:48 UTC (permalink / raw)
To: Sasha Levin; +Cc: akpm, linux-mm, linux-kernel
On Fri, Dec 27, 2013 at 05:40:18PM -0500, Sasha Levin wrote:
> I messed up and forgot to commit this fix before sending out the original
> patch.
>
> It fixes build issues in various files using VM_BUG_ON_PAGE.
With the patch applied I see this:
CC kernel/bounds.s
In file included from /home/space/kas/git/public/linux-next/include/linux/page-flags.h:10:0,
from /home/space/kas/git/public/linux-next/kernel/bounds.c:9:
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: ‘struct page’ declared inside parameter list [enabled by default]
extern void dump_page(struct page *page);
^
/home/space/kas/git/public/linux-next/include/linux/mmdebug.h:5:30: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
We need to declare struct page here as well.
diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 8bb64900da25..e8cec8bdda05 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -2,6 +2,7 @@
#define LINUX_MM_DEBUG_H 1
#ifdef CONFIG_DEBUG_VM
+struct page;
extern void dump_page(struct page *page);
#define VM_BUG_ON(cond) BUG_ON(cond)
#define VM_BUG_ON_PAGE(cond, page) \
--
Kirill A. Shutemov
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-30 10:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-27 22:40 [PATCH] mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE fix Sasha Levin
2013-12-30 10:48 ` Kirill A. Shutemov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox