From: Joerg Roedel <joro@8bytes.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
josh@joshtriplett.org
Subject: Re: [PATCH 1/3] drivers: iommu: Mark functions as static in dmar.c
Date: Mon, 30 Dec 2013 15:38:20 +0100 [thread overview]
Message-ID: <20131230143819.GE2799@8bytes.org> (raw)
In-Reply-To: <6d0cb39e3d1128669e7740943efce3996ab0d8ab.1387265904.git.rashika.kheria@gmail.com>
On Wed, Dec 18, 2013 at 12:01:46PM +0530, Rashika Kheria wrote:
> Mark the functions check_zero_address() and dmar_get_fault_reason() as
> static in dmar.c because they are not used outside this file.
>
> This eliminates the following warnings in dmar.c:
> drivers/iommu/dmar.c:491:12: warning: no previous prototype for ‘check_zero_address’ [-Wmissing-prototypes]
> drivers/iommu/dmar.c:1116:13: warning: no previous prototype for ‘dmar_get_fault_reason’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Applied all, thanks.
prev parent reply other threads:[~2013-12-30 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 6:31 [PATCH 1/3] drivers: iommu: Mark functions as static in dmar.c Rashika Kheria
2013-12-18 6:34 ` [PATCH 2/3] drivers: iommu: Mark functions as static in intel_irq_remapping.c Rashika Kheria
2013-12-18 6:36 ` [PATCH 3/3] drivers: iommu: Mark function eoi_ioapic_pin_remapped() as static in irq_remapping.c Rashika Kheria
2013-12-30 14:38 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131230143819.GE2799@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox