From: Stephen Hemminger <shemming@brocade.com>
To: David Howells <dhowells@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <keyrings@linux-nfs.org>
Subject: [PATCH] assoc_array: remove global variable
Date: Mon, 30 Dec 2013 15:20:10 -0800 [thread overview]
Message-ID: <20131230152010.2d26d75b@nehalam.linuxnetplumber.net> (raw)
The associative array code creates unnecessary and potentially problematic
global variable 'status'. Remove it since never used.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/lib/assoc_array.c 2013-12-20 07:59:47.468147094 -0800
+++ b/lib/assoc_array.c 2013-12-30 15:14:38.034880698 -0800
@@ -157,7 +157,7 @@ enum assoc_array_walk_status {
assoc_array_walk_tree_empty,
assoc_array_walk_found_terminal_node,
assoc_array_walk_found_wrong_shortcut,
-} status;
+};
struct assoc_array_walk_result {
struct {
next reply other threads:[~2013-12-30 23:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 23:20 Stephen Hemminger [this message]
2014-01-02 14:55 ` [PATCH] assoc_array: remove global variable David Howells
-- strict thread matches above, loose matches on Subject: below --
2014-01-23 13:24 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131230152010.2d26d75b@nehalam.linuxnetplumber.net \
--to=shemming@brocade.com \
--cc=dhowells@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox