* [PATCH] assoc_array: remove global variable
@ 2013-12-30 23:20 Stephen Hemminger
2014-01-02 14:55 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2013-12-30 23:20 UTC (permalink / raw)
To: David Howells; +Cc: linux-kernel, keyrings
The associative array code creates unnecessary and potentially problematic
global variable 'status'. Remove it since never used.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/lib/assoc_array.c 2013-12-20 07:59:47.468147094 -0800
+++ b/lib/assoc_array.c 2013-12-30 15:14:38.034880698 -0800
@@ -157,7 +157,7 @@ enum assoc_array_walk_status {
assoc_array_walk_tree_empty,
assoc_array_walk_found_terminal_node,
assoc_array_walk_found_wrong_shortcut,
-} status;
+};
struct assoc_array_walk_result {
struct {
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] assoc_array: remove global variable
@ 2014-01-23 13:24 David Howells
0 siblings, 0 replies; 3+ messages in thread
From: David Howells @ 2014-01-23 13:24 UTC (permalink / raw)
To: torvalds; +Cc: Stephen Hemminger, keyrings, linux-kernel
From: Stephen Hemminger <shemming@brocade.com>
The associative array code creates unnecessary and potentially problematic
global variable 'status'. Remove it since never used.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David Howells <dhowells@redhat.com>
---
lib/assoc_array.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/assoc_array.c b/lib/assoc_array.c
index 1b6a44f1ec3e..c0b1007011e1 100644
--- a/lib/assoc_array.c
+++ b/lib/assoc_array.c
@@ -157,7 +157,7 @@ enum assoc_array_walk_status {
assoc_array_walk_tree_empty,
assoc_array_walk_found_terminal_node,
assoc_array_walk_found_wrong_shortcut,
-} status;
+};
struct assoc_array_walk_result {
struct {
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-23 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-30 23:20 [PATCH] assoc_array: remove global variable Stephen Hemminger
2014-01-02 14:55 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2014-01-23 13:24 David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox