From: Pavel Machek <pavel@ucw.cz>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Ивайло Димитров" <freemangordon@abv.bg>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-bluetooth@vger.kernel.org development"
<linux-bluetooth@vger.kernel.org>,
"Ville Tervo" <ville.tervo@nokia.com>,
"Sebastian Reichel" <sre@ring0.de>
Subject: Re: [PATCH v2] Bluetooth: Add hci_h4p driver
Date: Mon, 30 Dec 2013 23:18:06 +0100 [thread overview]
Message-ID: <20131230221806.GA32561@amd.pavel.ucw.cz> (raw)
In-Reply-To: <C8D1F470-7964-4EAC-82E0-D53CF54DE086@holtmann.org>
Hi!
> > +config BT_HCIH4P
> > + tristate "HCI driver with H4 Nokia extensions"
> > + depends on BT && ARCH_OMAP
>
> Since then we moved away from doing hci_* prefix of drivers since that is misleading. See btusb.ko, btmrvl_sdio.ko etc.
>
> So this might be better named BT_NOK_H4P or BT_NOKIA_H4P and the module named btnok_h4p.ko or btnokia_h4p.ko.
>
Pali, please apply :-).
Pavel
commit b724166911dcdae2c43170ce4040427c00e834e3
Author: Pavel <pavel@ucw.cz>
Date: Mon Dec 30 23:16:25 2013 +0100
Rename nokia h4p driver object to btnokia_h4p.ko.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 9d46f23..a53e8c7 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -251,5 +251,5 @@ config BT_NOKIA_H4P
support for H4+ Bluetooth chip with vendor-specific H4 extensions.
Say Y here to compile support for h4 extended devices into the kernel
- or say M to compile it as module (hci_h4p).
+ or say M to compile it as module (btnokia_h4p).
endmenu
diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile
index c286dbe..a5ed271 100644
--- a/drivers/bluetooth/Makefile
+++ b/drivers/bluetooth/Makefile
@@ -31,7 +31,7 @@ hci_uart-$(CONFIG_BT_HCIUART_ATH3K) += hci_ath.o
hci_uart-$(CONFIG_BT_HCIUART_3WIRE) += hci_h5.o
hci_uart-objs := $(hci_uart-y)
-obj-$(CONFIG_BT_NOKIA_H4P) += hci_h4p.o
-hci_h4p-objs := nokia_core.o nokia_fw.o nokia_uart.o nokia_fw-csr.o \
+obj-$(CONFIG_BT_NOKIA_H4P) += btnokia_h4p.o
+btnokia_h4p-objs := nokia_core.o nokia_fw.o nokia_uart.o nokia_fw-csr.o \
nokia_fw-bcm.o nokia_fw-ti1273.o
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-12-30 22:18 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 19:01 [PATCH] Bluetooth: Add hci_h4p driver Pali Rohár
2013-10-17 20:25 ` Pali Rohár
2013-10-17 22:11 ` Marcel Holtmann
2013-10-18 10:30 ` Pali Rohár
2013-10-24 16:41 ` Pali Rohár
2013-10-24 18:41 ` Joe Perches
2013-10-26 19:28 ` Pali Rohár
2013-12-27 11:02 ` [PATCH v2] " Pali Rohár
2013-12-27 11:34 ` Pali Rohár
2013-12-28 1:21 ` Marcel Holtmann
2013-12-30 12:13 ` Pavel Machek
2013-12-30 12:25 ` Pavel Machek
2013-12-30 13:19 ` Sebastian Reichel
2013-12-30 14:04 ` Pali Rohár
2013-12-30 13:54 ` Pali Rohár
2013-12-30 12:23 ` Pavel Machek
2013-12-30 14:31 ` Pali Rohár
2013-12-30 14:52 ` Sebastian Reichel
2013-12-30 23:42 ` Sebastian Reichel
2014-01-08 21:36 ` Pali Rohár
2014-02-13 15:33 ` Pali Rohár
2014-02-14 17:28 ` Sebastian Reichel
2014-02-15 22:30 ` Pavel Machek
2014-02-19 1:12 ` Ben Hutchings
2013-12-30 22:18 ` Pavel Machek [this message]
2013-12-30 22:19 ` [PATCH] wilink: mention name of module in help text Pavel Machek
2013-12-30 22:28 ` [PATCH v2] Bluetooth: Add hci_h4p driver Pavel Machek
2013-12-30 22:48 ` Pavel Machek
2013-12-31 22:12 ` Pavel Machek
2013-12-31 23:23 ` Marcel Holtmann
2014-01-01 20:09 ` Pavel Machek
2014-01-02 16:18 ` [PATCH v3] " Pavel Machek
2014-01-02 16:34 ` Marcel Holtmann
2014-01-03 0:17 ` [PATCH v4] " Pavel Machek
2014-01-03 1:05 ` Sebastian Reichel
2014-01-05 22:32 ` Pavel Machek
2014-01-05 23:01 ` Sebastian Reichel
2014-01-06 0:27 ` Pavel Machek
2014-01-03 1:36 ` Sebastian Reichel
2014-01-09 23:38 ` Pavel Machek
2014-01-10 0:32 ` Sebastian Reichel
2014-01-10 12:18 ` Pavel Machek
2014-01-10 13:44 ` Sebastian Reichel
2014-01-10 14:49 ` Pavel Machek
2014-01-10 14:52 ` [PATCH v5] " Pavel Machek
2014-01-10 17:33 ` Joe Perches
2014-01-11 0:19 ` Pavel Machek
2014-01-11 0:28 ` [PATCH v6] " Pavel Machek
2014-01-16 0:22 ` Pavel Machek
2014-01-16 3:01 ` Marcel Holtmann
2014-01-17 12:14 ` Pavel Machek
2014-01-17 13:29 ` [PATCH v7] staging/bluetooth: " Pavel Machek
2014-01-17 13:34 ` [PATCH] Bluetooth: add module name for btwilink Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131230221806.GA32561@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=freemangordon@abv.bg \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pali.rohar@gmail.com \
--cc=sre@ring0.de \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).