public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arthur Schwalbenberg <arthurs578@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	lisa@xenapiadmin.com, linux-kernel@vger.kernel.org,
	himangi774@gmail.com
Subject: Re: [PATCH] Staging: bcm: Fixed excessive line lengths cleaned up some code
Date: Tue, 31 Dec 2013 14:01:27 +0300	[thread overview]
Message-ID: <20131231110127.GS28413@mwanda> (raw)
In-Reply-To: <1388404494-27647-1-git-send-email-arthurs578@gmail.com>

On Mon, Dec 30, 2013 at 06:54:54AM -0500, Arthur Schwalbenberg wrote:
> 	This is a patch to the Adapter.h file that fixes up excesssive
> 	line length warnings found by the checkpatch.pl tool
> 
> 	Signed off by: Arthur Schwalbenberg <arthurs578@gmail.com>

Don't indent the changelog like this.

Also the patch is wrong and breaks the driver.  You can't re-arrange
struct members which are a part of the user space API.

regards,
dan carpenter

      reply	other threads:[~2013-12-31 11:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30 11:54 [PATCH] Staging: bcm: Fixed excessive line lengths cleaned up some code Arthur Schwalbenberg
2013-12-31 11:01 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131231110127.GS28413@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=arthurs578@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=himangi774@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisa@xenapiadmin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox