From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756238AbcGHUIj (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jul 2016 16:08:39 -0400
Received: from mout.kundenserver.de ([212.227.126.187]:56197 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755520AbcGHUI3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jul 2016 16:08:29 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Shawn Lin <shawn.lin@rock-chips.com>, Bjorn Helgaas <bhelgaas@google.com>,
        Marc Zyngier <marc.zyngier@arm.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        Heiko Stuebner <heiko@sntech.de>,
        Doug Anderson <dianders@chromium.org>,
        Wenrui Li <wenrui.li@rock-chips.com>, Rob Herring <robh+dt@kernel.org>,
        devicetree@vger.kernel.org, Brian Norris <briannorris@chromium.org>
Subject: Re: [v6,2/2] PCI: Rockchip: Add Rockchip PCIe controller support
Date: Fri, 08 Jul 2016 22:10:14 +0200
Message-ID: <2013221.obfd8Z8cde@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20160708163511.GA23348@roeck-us.net>
References: <1467789398-13501-2-git-send-email-shawn.lin@rock-chips.com> <20160708163511.GA23348@roeck-us.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:B9Nyuuea8rs/l+oCqv93yL6OHwmBoySfItLlv2v4cYhVOvTtOjv
 NefGiDMpdjhkn372hNqi3qw4an7D/MqJHNrzTD4YThayC5feKA3i1X3ZWjuwJcrFspYuUOc
 p8FaajY6pktnYadoBStJnv9AQQm43herNf2M5nG8HcPbgWtsifzmrqCapwcfHuZs5WarPgt
 gPBIddUw7xgwYYUHKmdMQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:2Gfxuq+yL3U=:dpTzkBXzQBVleRJArDioYE
 xuAxjHujItKYK3Q8P6gJ9TOT+TEynWE1CawsiheJJGkRGKNsIjXVeEo2xSb2PPwJM9LHPAC/W
 6U3P5k3AuR7r5Gitlqyt08anBCwMPtDoS8ZhBgcXDQfs1kB9xZ+jwFZZYqh872VVOnx3DaeQy
 aK7R5Uf8FR8YxRyFMA/5GgiX3vqC7NdP12UKhIYglZ9y67LEpjB03qPbExTy3B61jjlrNT6Gb
 fIWrDwfnWfwjBRVi/oc846lMm2GKT28qWF1wYLRbTEliYY+6ane8MDLuYvSuRAOlejDX7iOG+
 XC3d3RftH55ZsDMDaL7kOEacAVSLzL33wlfFI/tqqwmUcC/CquEEmjFqmemMGXVTsP6d4cYfT
 632zT8YQZ7cZVux720G128cIwEtbs0W51DI3aBNoWRLBAPgubF7dkF2TRU25L8ltF/9Z4vbq+
 3sHqVv+66dG6t4HvXA6o2qFKkSTNztqJnD9R4A7aegRDxzy2hSEez0/yCXFYxyspWHmFRK0fF
 7PLhS31wdQDbk2u1WkqkB15TztaO8wAuYcW5TXZ89vjWveRejArYhTFnSPvdDumskU/Os8AdG
 Vzy50XooIKQL9cZ1j9SRR8qm+2pn4t4HKaKCu23hBs9pmCMAuRVPK+IWe6kB0Ja3qsxMNehlo
 Qda44f0X0AolbsCMnpVbpBl3wtEjpSbTyt+Tm6e4ggJX8GzRNE2VjK/0Hfw20s2abmUFmiWGy
 gZTdI7LVxv8KUTWI
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, July 8, 2016 9:35:11 AM CEST Guenter Roeck wrote:
> On Wed, Jul 06, 2016 at 03:16:38PM +0800, Shawn Lin wrote:
> > This patch adds Rockchip PCIe controller support found
> > on RK3399 Soc platform.
> > 
> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> > ---
> 
> [ ... ]
> 
> > +     /* Get the I/O and memory ranges from DT */
> > +     resource_list_for_each_entry(win, &res) {
> > +             switch (resource_type(win->res)) {
> > +             case IORESOURCE_IO:
> > +                     io = win->res;
> > +                     io->name = "I/O";
> > +                     io_size = resource_size(io);
> > +                     io_bus_addr = io->start - win->offset;
> > +                     err = pci_remap_iospace(io, io_base);
> 
> This function is not exported. Either it will have to be exported
> (which may be difficult since it is declared as __weak), or the
> driver must only be built into the kernel, or the function can
> not be used.
> 

I think we can simply drop the __weak annotation, there is no other
implementation of this, and I doubt there will ever be. Even if it
was needed, we could do it in a different way.

	Arnd