* [PATCH v2] Staging: rtl8188eu: Fixed coding style issues
@ 2014-01-02 20:46 Tim Jester-Pfadt
2014-01-02 21:37 ` Larry Finger
2014-01-02 23:22 ` [PATCH v3] " Tim Jester-Pfadt
0 siblings, 2 replies; 7+ messages in thread
From: Tim Jester-Pfadt @ 2014-01-02 20:46 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, devel, linux-kernel
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
index 10c9c65..6be6c50 100644
--- a/drivers/staging/rtl8188eu/core/rtw_io.c
+++ b/drivers/staging/rtl8188eu/core/rtw_io.c
@@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
_func_enter_;
if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
- RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
- ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
- adapter->bDriverStopped, adapter->bSurpriseRemoved));
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
+ adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}
_read_mem = pintfhdl->io_ops._read_mem;
@@ -239,9 +239,9 @@ void _rtw_read_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
_func_enter_;
if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
- RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
- ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
- adapter->bDriverStopped, adapter->bSurpriseRemoved));
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
+ adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}
--
1.8.5.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] Staging: rtl8188eu: Fixed coding style issues
2014-01-02 20:46 [PATCH v2] Staging: rtl8188eu: Fixed coding style issues Tim Jester-Pfadt
@ 2014-01-02 21:37 ` Larry Finger
2014-01-02 23:22 ` [PATCH v3] " Tim Jester-Pfadt
1 sibling, 0 replies; 7+ messages in thread
From: Larry Finger @ 2014-01-02 21:37 UTC (permalink / raw)
To: Tim Jester-Pfadt, gregkh; +Cc: devel, linux-kernel
On 01/02/2014 02:46 PM, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
>
> Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
> ---
> drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
> index 10c9c65..6be6c50 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_io.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_io.c
> @@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>
> _func_enter_;
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> - ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> - adapter->bDriverStopped, adapter->bSurpriseRemoved));
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> + adapter->bDriverStopped, adapter->bSurpriseRemoved));
The latest version of checkpatch.pl lists the following:
CHECK: Alignment should match open parenthesis
#87: FILE: drivers/staging/rtl8188eu/core/rtw_io.c:207:
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
The continuing lines should be indented one more space.
Larry
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] Staging: rtl8188eu: Fixed coding style issues
2014-01-02 20:46 [PATCH v2] Staging: rtl8188eu: Fixed coding style issues Tim Jester-Pfadt
2014-01-02 21:37 ` Larry Finger
@ 2014-01-02 23:22 ` Tim Jester-Pfadt
2014-01-02 23:33 ` Larry Finger
` (2 more replies)
1 sibling, 3 replies; 7+ messages in thread
From: Tim Jester-Pfadt @ 2014-01-02 23:22 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, devel, linux-kernel
Fixed indentation coding style issues on rtw_io.c
Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
index 10c9c65..f1b8dfe 100644
--- a/drivers/staging/rtl8188eu/core/rtw_io.c
+++ b/drivers/staging/rtl8188eu/core/rtw_io.c
@@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
_func_enter_;
if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
- RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
- ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
- adapter->bDriverStopped, adapter->bSurpriseRemoved));
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
+ adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}
_read_mem = pintfhdl->io_ops._read_mem;
@@ -239,9 +239,9 @@ void _rtw_read_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
_func_enter_;
if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
- RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
- ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
- adapter->bDriverStopped, adapter->bSurpriseRemoved));
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
+ adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}
--
1.8.5.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues
2014-01-02 23:22 ` [PATCH v3] " Tim Jester-Pfadt
@ 2014-01-02 23:33 ` Larry Finger
2014-01-03 3:58 ` Joe Perches
2014-01-03 7:55 ` Dan Carpenter
2 siblings, 0 replies; 7+ messages in thread
From: Larry Finger @ 2014-01-02 23:33 UTC (permalink / raw)
To: Tim Jester-Pfadt, gregkh; +Cc: devel, linux-kernel
On 01/02/2014 05:22 PM, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
>
> Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
> ---
> drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
> index 10c9c65..f1b8dfe 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_io.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_io.c
> @@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>
> _func_enter_;
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> - ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> - adapter->bDriverStopped, adapter->bSurpriseRemoved));
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> + adapter->bDriverStopped, adapter->bSurpriseRemoved));
> return;
> }
> _read_mem = pintfhdl->io_ops._read_mem;
> @@ -239,9 +239,9 @@ void _rtw_read_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
> _func_enter_;
>
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> - ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> - adapter->bDriverStopped, adapter->bSurpriseRemoved));
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> + adapter->bDriverStopped, adapter->bSurpriseRemoved));
> return;
> }
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues
2014-01-02 23:22 ` [PATCH v3] " Tim Jester-Pfadt
2014-01-02 23:33 ` Larry Finger
@ 2014-01-03 3:58 ` Joe Perches
2014-01-03 7:55 ` Dan Carpenter
2 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2014-01-03 3:58 UTC (permalink / raw)
To: Tim Jester-Pfadt; +Cc: gregkh, Larry.Finger, devel, linux-kernel
On Fri, 2014-01-03 at 00:22 +0100, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
[]
> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
[]
> @@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>
> _func_enter_;
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> - ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> - adapter->bDriverStopped, adapter->bSurpriseRemoved));
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> + adapter->bDriverStopped, adapter->bSurpriseRemoved));
Be nice to remove the unnecessary parentheses on all of these too
RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
"rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
adapter->bDriverStopped, adapter->bSurpriseRemoved);
etc...
A few other things too:
o The _func_enter_ uses are unnecessary and could/should
be removed. There's a standard function tracing capability.
o The RT_TRACE uses that embed a function name could/should use
%s:, __func__
o The RT_TRACE macro doesn't add a terminating newline and these
uses should have them.
RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
"%s:bDriverStopped(%d) OR bSurpriseRemoved(%d)\n",
__func__, adapter->bDriverStopped, adapter->bSurpriseRemoved);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues
2014-01-02 23:22 ` [PATCH v3] " Tim Jester-Pfadt
2014-01-02 23:33 ` Larry Finger
2014-01-03 3:58 ` Joe Perches
@ 2014-01-03 7:55 ` Dan Carpenter
2014-01-03 12:09 ` Tim Jester-Pfadt
2 siblings, 1 reply; 7+ messages in thread
From: Dan Carpenter @ 2014-01-03 7:55 UTC (permalink / raw)
To: Tim Jester-Pfadt; +Cc: gregkh, devel, linux-kernel, Larry.Finger
On Fri, Jan 03, 2014 at 12:22:59AM +0100, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
>
> Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
> ---
Next time, if you do a v2 patch please put a note here under the ---
line what changed between the previous one and this one.
2: changed blah blah blah.
> drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues
2014-01-03 7:55 ` Dan Carpenter
@ 2014-01-03 12:09 ` Tim Jester-Pfadt
0 siblings, 0 replies; 7+ messages in thread
From: Tim Jester-Pfadt @ 2014-01-03 12:09 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, devel, linux-kernel, Larry.Finger
Thank you for your feedback.
I'm still figuring stuff out. Submitting patches to the kernel has
been my new year's resolution.
Regards,
Tim
2014/1/3 Dan Carpenter <dan.carpenter@oracle.com>:
> On Fri, Jan 03, 2014 at 12:22:59AM +0100, Tim Jester-Pfadt wrote:
>> Fixed indentation coding style issues on rtw_io.c
>>
>> Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
>> ---
> Next time, if you do a v2 patch please put a note here under the ---
> line what changed between the previous one and this one.
>
> 2: changed blah blah blah.
>
>> drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-01-03 12:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-02 20:46 [PATCH v2] Staging: rtl8188eu: Fixed coding style issues Tim Jester-Pfadt
2014-01-02 21:37 ` Larry Finger
2014-01-02 23:22 ` [PATCH v3] " Tim Jester-Pfadt
2014-01-02 23:33 ` Larry Finger
2014-01-03 3:58 ` Joe Perches
2014-01-03 7:55 ` Dan Carpenter
2014-01-03 12:09 ` Tim Jester-Pfadt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox