* [PATCH] ASoC: pcm: Fix lack of platform bespoke_trigger() call
@ 2014-01-03 8:19 Jean-Francois Moine
2014-01-07 17:11 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Jean-Francois Moine @ 2014-01-03 8:19 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, linux-kernel
When the platform driver has no ops, the platform function
bespoke_trigger() is no more called.
The problem was introduced by the commit c5914b0aaea6494aaa9e415cbd32f8b7eb604af0
"ASoC: pcm: Check for ops before deferencing them"
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
sound/soc/soc-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 891b9a9..df79101 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -672,7 +672,7 @@ static int soc_pcm_bespoke_trigger(struct snd_pcm_substream *substream,
return ret;
}
- if (platform->driver->ops && platform->driver->bespoke_trigger) {
+ if (platform->driver->bespoke_trigger) {
ret = platform->driver->bespoke_trigger(substream, cmd);
if (ret < 0)
return ret;
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: pcm: Fix lack of platform bespoke_trigger() call
2014-01-03 8:19 [PATCH] ASoC: pcm: Fix lack of platform bespoke_trigger() call Jean-Francois Moine
@ 2014-01-07 17:11 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-01-07 17:11 UTC (permalink / raw)
To: Jean-Francois Moine; +Cc: Liam Girdwood, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
On Fri, Jan 03, 2014 at 09:19:18AM +0100, Jean-Francois Moine wrote:
> When the platform driver has no ops, the platform function
> bespoke_trigger() is no more called.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-07 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-03 8:19 [PATCH] ASoC: pcm: Fix lack of platform bespoke_trigger() call Jean-Francois Moine
2014-01-07 17:11 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox