From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan LaManna <dan.lamanna@gmail.com>
Cc: devel@driverdev.osuosl.org, andrea.merello@gmail.com,
gregkh@linuxfoundation.org, rusty@rustcorp.com.au,
linville@tuxdriver.com, linux-kernel@vger.kernel.org,
teobaluta@gmail.com
Subject: Re: [PATCH] Staging: rtl8187se: fix styling issues in r8180_wx.c
Date: Mon, 6 Jan 2014 00:56:03 +0300 [thread overview]
Message-ID: <20140105215603.GI30234@mwanda> (raw)
In-Reply-To: <20140105214555.GH30234@mwanda>
On Mon, Jan 06, 2014 at 12:45:55AM +0300, Dan Carpenter wrote:
> On Sun, Jan 05, 2014 at 04:17:36PM -0500, Dan LaManna wrote:
> > @@ -1358,22 +1358,22 @@ static inline int is_same_network(struct ieee80211_network *src,
> > * We treat all <hidden> with the same BSSID and channel
> > * as one network
> > */
> > - return (((src->ssid_len == dst->ssid_len) || (ieee->iw_mode == IW_MODE_INFRA)) && /* YJ,mod, 080819,for hidden ap */
> > + return ((src->ssid_len == dst->ssid_len) || (ieee->iw_mode == IW_MODE_INFRA)) && /* YJ,mod, 080819,for hidden ap */
> > (src->channel == dst->channel) &&
> > !memcmp(src->bssid, dst->bssid, ETH_ALEN) &&
> > (!memcmp(src->ssid, dst->ssid, src->ssid_len) || (ieee->iw_mode == IW_MODE_INFRA)) && /* YJ,mod, 080819,for hidden ap */
> > ((src->capability & WLAN_CAPABILITY_IBSS) ==
> > (dst->capability & WLAN_CAPABILITY_IBSS)) &&
> > ((src->capability & WLAN_CAPABILITY_BSS) ==
> > - (dst->capability & WLAN_CAPABILITY_BSS)));
> > + (dst->capability & WLAN_CAPABILITY_BSS));
> > }
> >
>
> Break this up.
>
> if (src->channel != dst->channel)
> return 0;
>
> if (memcmp(src->bssid, dst->bssid, ETH_ALEN) != 0)
> return 0;
>
> if (ieee->iw_mode == IW_MODE_INFRA) {
I have this one reversed. It should be:
if (ieee->iw_mode != IW_MODE_INFRA) {
regards,
dan carpenter
next prev parent reply other threads:[~2014-01-05 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 21:17 [PATCH] Staging: rtl8187se: fix styling issues in r8180_wx.c Dan LaManna
2014-01-05 21:45 ` Dan Carpenter
2014-01-05 21:56 ` Dan Carpenter [this message]
2014-01-05 22:49 ` Joe Perches
2014-01-06 7:51 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140105215603.GI30234@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrea.merello@gmail.com \
--cc=dan.lamanna@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rusty@rustcorp.com.au \
--cc=teobaluta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox