From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andreas Frembs <andreas.frembs@studium.uni-erlangen.de>
Cc: devel@driverdev.osuosl.org, lisa@xenapiadmin.com,
linux-kernel@i4.cs.fau.de, andrea.merello@gmail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
matthias.schoepe@studium.uni-erlangen.de, dhowells@redhat.com,
valentina.manea.m@gmail.com, viro@zeniv.linux.org.uk,
linville@tuxdriver.com
Subject: Re: [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error in rtllib_debug.h
Date: Mon, 6 Jan 2014 11:05:20 +0300 [thread overview]
Message-ID: <20140106080520.GK30234@mwanda> (raw)
In-Reply-To: <1388924737-1412-3-git-send-email-andreas.frembs@studium.uni-erlangen.de>
On Sun, Jan 05, 2014 at 01:25:36PM +0100, Andreas Frembs wrote:
> In rtllib_debug.h we fixed the following checkpatch error:
> ERROR: Macros with complex values should be enclosed in parenthesis
>
> We fixed this with a do {} while (0), because otherwise the compiler complained.
>
> Signed-off-by: Andreas Frembs <andreas.frembs@studium.uni-erlangen.de>
> Signed-off-by: Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de>
It would be better to replace these with WARN_ON(). I haven't looked
but I also suspect that some of these asserts might be bogus and should
be removed.
regards,
dan carpenter
next prev parent reply other threads:[~2014-01-06 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 12:25 [PATCH 0/3] Staging rtl8192e: Fixing several checkpatch errors and warnings Andreas Frembs
2014-01-05 12:25 ` [PATCH 1/3] Staging rtl8192e: Fixing checkpatch error in rtllib_crypt_tkip.c Andreas Frembs
2014-01-05 12:25 ` [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error in rtllib_debug.h Andreas Frembs
2014-01-06 8:05 ` Dan Carpenter [this message]
2014-01-05 12:25 ` [PATCH 3/3] Staging rtl8192e: Correcting wrong usage of macro in r8192E_phy.c and removing corresponding warning " Andreas Frembs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106080520.GK30234@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrea.merello@gmail.com \
--cc=andreas.frembs@studium.uni-erlangen.de \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lisa@xenapiadmin.com \
--cc=matthias.schoepe@studium.uni-erlangen.de \
--cc=valentina.manea.m@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox