From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aruna-Hewapathirane <aruna.hewapathirane@gmail.com>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
Date: Mon, 6 Jan 2014 12:09:34 +0300 [thread overview]
Message-ID: <20140106090933.GM30234@mwanda> (raw)
In-Reply-To: <1388998839-28799-1-git-send-email-aruna.hewapathirane@gmail.com>
Changelog mangled. You need a blank after the subject.
On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote:
> ---
> drivers/staging/comedi/drivers/ke_counter.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c
> index 15589f6..cebf818 100644
> --- a/drivers/staging/comedi/drivers/ke_counter.c
> +++ b/drivers/staging/comedi/drivers/ke_counter.c
> @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
> dev->read_subdev = s;
> s->type = COMEDI_SUBD_COUNTER;
> - s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ;
> + s->subdev_flags = SDF_READABLE /* | SDF_COMMON */;
> s->n_chan = 3;
> s->maxdata = 0x00ffffff;
> s->insn_read = cnt_rinsn;
> @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
> outb(0, dev->iobase + 0x40);
> dev_info(dev->class_dev, "%s: %s attached\n",
> - dev->driver->driver_name, dev->board_name);
> + dev->driver->driver_name, dev->board_name);
Nope. The original was better.
regards,
dan carpenter
> return 0;
> }
> --
> 1.7.0.4
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2014-01-06 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 9:00 [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com> Aruna-Hewapathirane
2014-01-06 9:09 ` Dan Carpenter [this message]
2014-01-06 9:18 ` Aruna Hewapathirane
2014-01-06 9:23 ` Dan Carpenter
2014-01-06 9:30 ` Aruna Hewapathirane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106090933.GM30234@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=aruna.hewapathirane@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox