From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233AbaAFJJv (ORCPT ); Mon, 6 Jan 2014 04:09:51 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:44246 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751063AbaAFJJq (ORCPT ); Mon, 6 Jan 2014 04:09:46 -0500 Date: Mon, 6 Jan 2014 12:09:34 +0300 From: Dan Carpenter To: Aruna-Hewapathirane Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane Message-ID: <20140106090933.GM30234@mwanda> References: <1388998839-28799-1-git-send-email-aruna.hewapathirane@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1388998839-28799-1-git-send-email-aruna.hewapathirane@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changelog mangled. You need a blank after the subject. On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote: > --- > drivers/staging/comedi/drivers/ke_counter.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c > index 15589f6..cebf818 100644 > --- a/drivers/staging/comedi/drivers/ke_counter.c > +++ b/drivers/staging/comedi/drivers/ke_counter.c > @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev, > dev->read_subdev = s; > s->type = COMEDI_SUBD_COUNTER; > - s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ; > + s->subdev_flags = SDF_READABLE /* | SDF_COMMON */; > s->n_chan = 3; > s->maxdata = 0x00ffffff; > s->insn_read = cnt_rinsn; > @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev, > outb(0, dev->iobase + 0x40); > dev_info(dev->class_dev, "%s: %s attached\n", > - dev->driver->driver_name, dev->board_name); > + dev->driver->driver_name, dev->board_name); Nope. The original was better. regards, dan carpenter > return 0; > } > -- > 1.7.0.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel