* [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
@ 2014-01-06 9:00 Aruna-Hewapathirane
2014-01-06 9:09 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Aruna-Hewapathirane @ 2014-01-06 9:00 UTC (permalink / raw)
To: abbotti
Cc: hsweeten, gregkh, peterhuewe, devel, linux-kernel,
Aruna-Hewapathirane
---
drivers/staging/comedi/drivers/ke_counter.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c
index 15589f6..cebf818 100644
--- a/drivers/staging/comedi/drivers/ke_counter.c
+++ b/drivers/staging/comedi/drivers/ke_counter.c
@@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
dev->read_subdev = s;
s->type = COMEDI_SUBD_COUNTER;
- s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ;
+ s->subdev_flags = SDF_READABLE /* | SDF_COMMON */;
s->n_chan = 3;
s->maxdata = 0x00ffffff;
s->insn_read = cnt_rinsn;
@@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
outb(0, dev->iobase + 0x40);
dev_info(dev->class_dev, "%s: %s attached\n",
- dev->driver->driver_name, dev->board_name);
+ dev->driver->driver_name, dev->board_name);
return 0;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
2014-01-06 9:00 [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com> Aruna-Hewapathirane
@ 2014-01-06 9:09 ` Dan Carpenter
2014-01-06 9:18 ` Aruna Hewapathirane
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2014-01-06 9:09 UTC (permalink / raw)
To: Aruna-Hewapathirane; +Cc: abbotti, devel, gregkh, linux-kernel
Changelog mangled. You need a blank after the subject.
On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote:
> ---
> drivers/staging/comedi/drivers/ke_counter.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c
> index 15589f6..cebf818 100644
> --- a/drivers/staging/comedi/drivers/ke_counter.c
> +++ b/drivers/staging/comedi/drivers/ke_counter.c
> @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
> dev->read_subdev = s;
> s->type = COMEDI_SUBD_COUNTER;
> - s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ;
> + s->subdev_flags = SDF_READABLE /* | SDF_COMMON */;
> s->n_chan = 3;
> s->maxdata = 0x00ffffff;
> s->insn_read = cnt_rinsn;
> @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
> outb(0, dev->iobase + 0x40);
> dev_info(dev->class_dev, "%s: %s attached\n",
> - dev->driver->driver_name, dev->board_name);
> + dev->driver->driver_name, dev->board_name);
Nope. The original was better.
regards,
dan carpenter
> return 0;
> }
> --
> 1.7.0.4
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
2014-01-06 9:09 ` Dan Carpenter
@ 2014-01-06 9:18 ` Aruna Hewapathirane
2014-01-06 9:23 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Aruna Hewapathirane @ 2014-01-06 9:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: abbotti, devel, gregkh, linux-kernel
my apologies, it's my very first patch :-)
On Mon, Jan 6, 2014 at 4:09 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Changelog mangled. You need a blank after the subject.
>
> On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote:
>> ---
>> drivers/staging/comedi/drivers/ke_counter.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c
>> index 15589f6..cebf818 100644
>> --- a/drivers/staging/comedi/drivers/ke_counter.c
>> +++ b/drivers/staging/comedi/drivers/ke_counter.c
>> @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
>> dev->read_subdev = s;
>> s->type = COMEDI_SUBD_COUNTER;
>> - s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ;
>> + s->subdev_flags = SDF_READABLE /* | SDF_COMMON */;
>> s->n_chan = 3;
>> s->maxdata = 0x00ffffff;
>> s->insn_read = cnt_rinsn;
>> @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
>> outb(0, dev->iobase + 0x40);
>> dev_info(dev->class_dev, "%s: %s attached\n",
>> - dev->driver->driver_name, dev->board_name);
>> + dev->driver->driver_name, dev->board_name);
>
> Nope. The original was better.
>
> regards,
> dan carpenter
>
>> return 0;
>> }
>> --
>> 1.7.0.4
>>
>> _______________________________________________
>> devel mailing list
>> devel@linuxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
Aruna Hewapathirane
Consultant/Trainer
Phone : 647-709-9269
Website: Open Source Solutions
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
2014-01-06 9:18 ` Aruna Hewapathirane
@ 2014-01-06 9:23 ` Dan Carpenter
2014-01-06 9:30 ` Aruna Hewapathirane
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2014-01-06 9:23 UTC (permalink / raw)
To: Aruna Hewapathirane; +Cc: abbotti, devel, gregkh, linux-kernel
On Mon, Jan 06, 2014 at 04:18:05AM -0500, Aruna Hewapathirane wrote:
> my apologies, it's my very first patch :-)
>
No worries. Take your time. We were all newbies once.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
2014-01-06 9:23 ` Dan Carpenter
@ 2014-01-06 9:30 ` Aruna Hewapathirane
0 siblings, 0 replies; 5+ messages in thread
From: Aruna Hewapathirane @ 2014-01-06 9:30 UTC (permalink / raw)
To: Dan Carpenter; +Cc: abbotti, devel, gregkh, linux-kernel
To be honest I almost fell off the chair when your email pooped up in
my in-box, that has to be the fastest anyone has ever responded and it
is yet very much a learning process for me, have so much to learn.I am
humbled and thankful you have not forgotten what it was like when you
sent in that first patch :-)
On Mon, Jan 6, 2014 at 4:23 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Jan 06, 2014 at 04:18:05AM -0500, Aruna Hewapathirane wrote:
>> my apologies, it's my very first patch :-)
>>
>
> No worries. Take your time. We were all newbies once.
>
> regards,
> dan carpenter
>
--
Aruna Hewapathirane
Consultant/Trainer
Phone : 647-709-9269
Website: Open Source Solutions
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-06 9:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-06 9:00 [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com> Aruna-Hewapathirane
2014-01-06 9:09 ` Dan Carpenter
2014-01-06 9:18 ` Aruna Hewapathirane
2014-01-06 9:23 ` Dan Carpenter
2014-01-06 9:30 ` Aruna Hewapathirane
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox