* [PATCH 1/2] mfd: twl6040: Staticize local variable
@ 2013-12-21 5:52 Sachin Kamat
2013-12-21 5:52 ` [PATCH 2/2] mfd: rtl8411: Staticize local symbol Sachin Kamat
2014-01-06 9:30 ` [PATCH 1/2] mfd: twl6040: Staticize local variable Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-12-21 5:52 UTC (permalink / raw)
To: linux-kernel; +Cc: lee.jones, sameo, sachin.kamat, Peter Ujfalusi
'twl6040_patch' is local to this file.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/mfd/twl6040.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
index 51b6df1a7949..75316fb33448 100644
--- a/drivers/mfd/twl6040.c
+++ b/drivers/mfd/twl6040.c
@@ -86,7 +86,7 @@ static struct reg_default twl6040_defaults[] = {
{ 0x2E, 0x00 }, /* REG_STATUS (ro) */
};
-struct reg_default twl6040_patch[] = {
+static struct reg_default twl6040_patch[] = {
/* Select I2C bus access to dual access registers */
{ TWL6040_REG_ACCCTL, 0x09 },
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] mfd: rtl8411: Staticize local symbol
2013-12-21 5:52 [PATCH 1/2] mfd: twl6040: Staticize local variable Sachin Kamat
@ 2013-12-21 5:52 ` Sachin Kamat
2014-01-06 9:30 ` Lee Jones
2014-01-06 9:30 ` [PATCH 1/2] mfd: twl6040: Staticize local variable Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2013-12-21 5:52 UTC (permalink / raw)
To: linux-kernel; +Cc: lee.jones, sameo, sachin.kamat
'rtl8411_init_common_params' is local to this file.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mfd/rtl8411.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rtl8411.c b/drivers/mfd/rtl8411.c
index ada38ad54e87..fdd34c883d86 100644
--- a/drivers/mfd/rtl8411.c
+++ b/drivers/mfd/rtl8411.c
@@ -470,7 +470,7 @@ static const u32 rtl8411b_qfn48_ms_pull_ctl_disable_tbl[] = {
0,
};
-void rtl8411_init_common_params(struct rtsx_pcr *pcr)
+static void rtl8411_init_common_params(struct rtsx_pcr *pcr)
{
pcr->extra_caps = EXTRA_CAPS_SD_SDR50 | EXTRA_CAPS_SD_SDR104;
pcr->num_slots = 2;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mfd: twl6040: Staticize local variable
2013-12-21 5:52 [PATCH 1/2] mfd: twl6040: Staticize local variable Sachin Kamat
2013-12-21 5:52 ` [PATCH 2/2] mfd: rtl8411: Staticize local symbol Sachin Kamat
@ 2014-01-06 9:30 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2014-01-06 9:30 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, sameo, Peter Ujfalusi
On Sat, 21 Dec 2013, Sachin Kamat wrote:
> 'twl6040_patch' is local to this file.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/mfd/twl6040.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index 51b6df1a7949..75316fb33448 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -86,7 +86,7 @@ static struct reg_default twl6040_defaults[] = {
> { 0x2E, 0x00 }, /* REG_STATUS (ro) */
> };
>
> -struct reg_default twl6040_patch[] = {
> +static struct reg_default twl6040_patch[] = {
> /* Select I2C bus access to dual access registers */
> { TWL6040_REG_ACCCTL, 0x09 },
> };
This has already been fixed.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] mfd: rtl8411: Staticize local symbol
2013-12-21 5:52 ` [PATCH 2/2] mfd: rtl8411: Staticize local symbol Sachin Kamat
@ 2014-01-06 9:30 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2014-01-06 9:30 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, sameo
On Sat, 21 Dec 2013, Sachin Kamat wrote:
> 'rtl8411_init_common_params' is local to this file.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mfd/rtl8411.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/rtl8411.c b/drivers/mfd/rtl8411.c
> index ada38ad54e87..fdd34c883d86 100644
> --- a/drivers/mfd/rtl8411.c
> +++ b/drivers/mfd/rtl8411.c
> @@ -470,7 +470,7 @@ static const u32 rtl8411b_qfn48_ms_pull_ctl_disable_tbl[] = {
> 0,
> };
>
> -void rtl8411_init_common_params(struct rtsx_pcr *pcr)
> +static void rtl8411_init_common_params(struct rtsx_pcr *pcr)
> {
> pcr->extra_caps = EXTRA_CAPS_SD_SDR50 | EXTRA_CAPS_SD_SDR104;
> pcr->num_slots = 2;
This has already been fixed.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-06 9:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-21 5:52 [PATCH 1/2] mfd: twl6040: Staticize local variable Sachin Kamat
2013-12-21 5:52 ` [PATCH 2/2] mfd: rtl8411: Staticize local symbol Sachin Kamat
2014-01-06 9:30 ` Lee Jones
2014-01-06 9:30 ` [PATCH 1/2] mfd: twl6040: Staticize local variable Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox