From: Pavel Machek <pavel@ucw.cz>
To: Joe Perches <joe@perches.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
keescook@chromium.org, akpm@linux-foundation.org,
geert@linux-m68k.org, jkosina@suse.cz, viro@zeniv.linux.org.uk,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/vsprintf: add %pT[C012] format specifier
Date: Tue, 7 Jan 2014 01:16:04 +0100 [thread overview]
Message-ID: <20140107001604.GD24243@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1389047143.2433.14.camel@joe-AO722>
Hi!
> > > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> > > []
> > > > @@ -1232,7 +1248,7 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr,
> > > > {
> > > > int default_width = 2 * sizeof(void *) + (spec.flags & SPECIAL ? 2 : 0);
> > > >
> > > > - if (!ptr && *fmt != 'K') {
> > > > + if (!ptr && *fmt != 'K' && *fmt != 'T') {
> > >
> > > I think this new 'T' comparison isn't necessary.
> >
> > This is needed for allowing comm_name() to accept NULL instead of current.
>
> Yeah, that's what I think isn't necessary.
>
> current is current_thread_info()->task.
>
> I think it's pretty lightweight in all arches and
> it'd be simpler/more intelligible to not use NULL.
>
> Andrew? Any opinion? Anyone else?
Andrew was worried about all the "current" duplication, IIRC. It is in
the mail thread somewhere. And one condition in printk is price worth paying.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-01-07 0:16 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 12:37 [PATCH] lib/vsprintf: add %pT[C012] format specifier Tetsuo Handa
2013-12-26 8:43 ` Joe Perches
2013-12-27 23:02 ` Andrew Morton
2013-12-28 3:43 ` Tetsuo Handa
2013-12-28 18:57 ` Geert Uytterhoeven
2013-12-28 19:25 ` Andrew Morton
2013-12-28 19:25 ` Geert Uytterhoeven
2013-12-28 19:53 ` Joe Perches
2013-12-28 20:08 ` Andrew Morton
2013-12-28 20:24 ` Joe Perches
2013-12-29 0:32 ` Tetsuo Handa
2013-12-29 2:07 ` Joe Perches
2013-12-29 12:13 ` Tetsuo Handa
2013-12-30 16:55 ` Joe Perches
2013-12-31 6:53 ` Tetsuo Handa
2013-12-31 16:24 ` Joe Perches
2014-01-01 5:34 ` Tetsuo Handa
2014-01-01 5:49 ` Joe Perches
2014-01-01 10:02 ` Tetsuo Handa
2014-01-02 1:33 ` Joe Perches
2014-01-02 4:49 ` Tetsuo Handa
2014-01-03 17:08 ` Kees Cook
2014-01-03 17:39 ` Joe Perches
2014-01-03 17:49 ` Kees Cook
2014-01-04 2:26 ` Tetsuo Handa
2014-01-05 3:15 ` Tetsuo Handa
2014-01-05 18:09 ` Joe Perches
2014-01-06 14:00 ` Tetsuo Handa
2014-01-06 17:34 ` Joe Perches
2014-01-06 21:41 ` Tetsuo Handa
2014-01-06 22:25 ` Joe Perches
2014-01-07 0:16 ` Pavel Machek [this message]
2014-01-07 1:03 ` Joe Perches
2014-01-07 8:37 ` Pavel Machek
2014-01-07 17:34 ` Joe Perches
2014-01-07 17:56 ` Pavel Machek
2014-01-07 18:28 ` Geert Uytterhoeven
2014-01-08 14:19 ` Tetsuo Handa
2014-01-08 14:46 ` Pavel Machek
2014-01-06 21:34 ` Pavel Machek
2014-01-05 22:27 ` Pavel Machek
2014-01-06 14:02 ` Tetsuo Handa
2014-01-10 13:15 ` Tetsuo Handa
2014-01-02 1:38 ` Joe Perches
2014-01-02 11:51 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107001604.GD24243@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox