From: Lee Jones <lee.jones@linaro.org>
To: Laszlo Papp <lpapp@kde.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs
Date: Tue, 7 Jan 2014 09:09:38 +0000 [thread overview]
Message-ID: <20140107090938.GF3182@lee--X1> (raw)
In-Reply-To: <1387814889-16670-1-git-send-email-lpapp@kde.org>
Don't send private, off-list emails for poking or anything else
related to upstreamming patches.
> Important text here later. It is now just an attempt to get some feedback about
> the design of the new features. This set has only been compilation tested, and
> has many errors with checkpatch.pl, et al. Really, the point is only to get
> feedback about the direction, as there has been a lot of paid work put into
> this to work better with upstream after the previously rejected change simple
> hwmon change.
If you want to obtain time/advice from maintainers, most of which are
already snowed-under, you have to earn it. Making submissions such as
these are not conducive to your cause. Fix the Checkpatch errors and
do your damnedest to ensure the code is the finest standard it can be.
If you fail to adhere to these [1] three documents accidentally, then
you will be guided. If you do so on purpose by sending intentionally
sloppy code, then you are unlikely to gain any attention at all.
[1]
Documentation/CodingStyle
Documentation/email-clients.txt
Documentation/SubmittingPatches
> Laszlo Papp (3):
> mfd: MAX6650/6651 support
> hwmon: (max6650) Convert to be a platform driver
> gpio: MAX6650/6651 support
>
> drivers/gpio/Kconfig | 14 ++
> drivers/gpio/Makefile | 2 +
> drivers/gpio/gpio-max6651.c | 72 +++++++++
> drivers/gpio/gpio-max665x.c | 301 ++++++++++++++++++++++++++++++++++++
> drivers/hwmon/Kconfig | 2 +-
> drivers/hwmon/max6650.c | 150 +++++++++---------
> drivers/mfd/Kconfig | 11 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/max6651.c | 132 ++++++++++++++++
> include/linux/mfd/max6651-private.h | 63 ++++++++
> 10 files changed, 675 insertions(+), 73 deletions(-)
> create mode 100644 drivers/gpio/gpio-max6651.c
> create mode 100644 drivers/gpio/gpio-max665x.c
> create mode 100644 drivers/mfd/max6651.c
> create mode 100644 include/linux/mfd/max6651-private.h
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-01-07 9:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 16:08 [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs Laszlo Papp
2013-12-23 16:08 ` [PATCH 1/3] mfd: MAX6650/6651 support Laszlo Papp
2014-01-07 14:11 ` Linus Walleij
2014-01-08 14:39 ` Laszlo Papp
2014-01-08 22:39 ` Lee Jones
2014-01-09 2:15 ` Laszlo Papp
2014-01-09 9:41 ` Lee Jones
2014-01-09 10:33 ` Laszlo Papp
2014-01-09 11:06 ` Lee Jones
2014-01-09 11:11 ` Laszlo Papp
2014-01-09 11:21 ` Lee Jones
2014-01-09 14:43 ` Laszlo Papp
2014-01-10 9:56 ` Lee Jones
2014-01-15 8:02 ` Linus Walleij
2013-12-23 16:08 ` [PATCH 2/3] hwmon: (max6650) Convert to be a platform driver Laszlo Papp
2014-02-13 17:41 ` Laszlo Papp
2014-02-14 9:20 ` Lee Jones
2013-12-23 16:08 ` [PATCH 3/3] gpio: MAX6650/6651 support Laszlo Papp
2014-01-07 14:33 ` Linus Walleij
2014-01-08 14:59 ` Laszlo Papp
2014-01-13 9:22 ` Laszlo Papp
2014-01-13 9:48 ` Linus Walleij
2014-01-13 12:15 ` Laszlo Papp
2014-01-13 9:43 ` Linus Walleij
2014-01-13 12:12 ` Laszlo Papp
2014-01-14 17:17 ` Laszlo Papp
2014-01-15 10:05 ` Linus Walleij
2014-01-15 10:51 ` Laszlo Papp
2014-01-15 12:21 ` Linus Walleij
2014-01-07 9:09 ` Lee Jones [this message]
2014-01-08 14:37 ` [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs Laszlo Papp
2014-01-08 17:07 ` Laszlo Papp
2014-01-08 17:22 ` Lee Jones
2014-01-08 17:31 ` Laszlo Papp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107090938.GF3182@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lpapp@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).