public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Gunselmann <michael.gunselmann@studium.uni-erlangen.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	martin.hofmann@studium.uni-erlangen.de,
	forest@alittletooquiet.net
Subject: Re: [PATCHv2 1/7] vt6655: balance faulty parentheses in 80211hdr.h
Date: Tue, 7 Jan 2014 15:34:39 +0300	[thread overview]
Message-ID: <20140107123439.GP30234@mwanda> (raw)
In-Reply-To: <1389096711-8595-2-git-send-email-michael.gunselmann@studium.uni-erlangen.de>

On Tue, Jan 07, 2014 at 01:11:45PM +0100, Michael Gunselmann wrote:
> From: Martin Hofmann <martin.hofmann@studium.uni-erlangen.de>
> 
> The file 80211hdr.h contained the macro WLAN_GET_FC_PRVER(n). The big endian
> fashion of this macro had unbalanced parentheses. This patch removes the
> parentheses in question.
> 

Good fix.  Next time, mention that this fixes a compile error and put
the GCC changelog if you have it.

(Don't redo the patch, it's fine as-is).

regards,
dan carpenter


  reply	other threads:[~2014-01-07 12:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 12:11 [PATCHv2 0/7] vt6655: Cleanup of checkpatch errors Michael Gunselmann
2014-01-07 12:11 ` [PATCHv2 1/7] vt6655: balance faulty parentheses in 80211hdr.h Michael Gunselmann
2014-01-07 12:34   ` Dan Carpenter [this message]
2014-01-07 12:11 ` [PATCHv2 2/7] vt6655: remove casts in wroute.c Michael Gunselmann
2014-01-07 12:11 ` [PATCHv2 3/7] vt6655: remove unnecessary braces " Michael Gunselmann
2014-01-07 12:11 ` [PATCHv2 4/7] vt6655: fix indentation " Michael Gunselmann
2014-01-07 12:11 ` [PATCHv2 5/7] vt6655: remove typedefs in wpactl.h Michael Gunselmann
2014-01-07 12:11 ` [PATCHv2 6/7] vt6655: fix printk usage in wpactl.c Michael Gunselmann
2014-01-07 12:11 ` [PATCHv2 7/7] vt6655: Remove typedefs in 80211hdr.h Michael Gunselmann
2014-01-08 19:07   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140107123439.GP30234@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.hofmann@studium.uni-erlangen.de \
    --cc=michael.gunselmann@studium.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox