From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Hiroshi Doyu <hdoyu@nvidia.com>, Wolfram Sang <wsa@the-dreams.de>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>
Subject: Re: [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel
Date: Tue, 7 Jan 2014 14:54:04 +0200 [thread overview]
Message-ID: <20140107125404.GD26588@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <52CB0CFE.4070901@wwwdotorg.org>
On Mon, Jan 06, 2014 at 09:07:26PM +0100, Stephen Warren wrote:
> On 12/24/2013 06:32 AM, Peter De Schrijver wrote:
> > Export APB DMA readl and writel. These are needed because we can't access
> > the fuses directly on Tegra20 without potentially causing a system hang.
>
> This does a lot more than just export the functions; it also changes the
> prototypes. I'm not sure why the prototype change was required/useful.
> This needs to be mentioned in the commit description/subject, and the
> reasoning explained too.
>
> > diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h
>
> > +#if defined(CONFIG_TEGRA20_APB_DMA)
> > +void tegra_apb_io_init(void);
>
> This seems to be an internal function; why is this one publicly
> prototyped and/or stubbed?
>
Ah. this might be a leftover from a previous iteration... Need to check.
next prev parent reply other threads:[~2014-01-07 12:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 13:32 [PATCH v2 0/6] efuse driver for Tegra Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel Peter De Schrijver
2014-01-06 20:07 ` Stephen Warren
2014-01-07 12:54 ` Peter De Schrijver [this message]
2013-12-24 13:32 ` [PATCH v2 2/6] misc: fuse: Add efuse driver for Tegra Peter De Schrijver
2014-01-06 20:32 ` Stephen Warren
2014-01-07 14:05 ` Peter De Schrijver
2014-01-07 20:41 ` Stephen Warren
2013-12-24 13:32 ` [PATCH v2 3/6] ARM: tegra: Add efuse bindings Peter De Schrijver
2014-01-06 20:40 ` Stephen Warren
2014-01-08 13:39 ` Thierry Reding
2014-01-08 18:50 ` Stephen Warren
2014-01-08 20:05 ` Thierry Reding
2014-01-08 20:09 ` Thierry Reding
2014-01-08 22:41 ` Stephen Warren
2014-01-09 12:40 ` Thierry Reding
2013-12-24 13:32 ` [PATCH v2 4/6] ARM: tegra: rework fuse.c Peter De Schrijver
2014-01-03 11:19 ` Alexandre Courbot
2014-01-06 20:50 ` Stephen Warren
2014-01-07 14:10 ` Peter De Schrijver
2014-01-07 20:47 ` Stephen Warren
2014-01-08 8:31 ` Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 5/6] ARM: Tegra: remove speedo files Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 6/6] misc: enable fuse drivers Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107125404.GD26588@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=hdoyu@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pgaikwad@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).