From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752767AbaAGPuH (ORCPT ); Tue, 7 Jan 2014 10:50:07 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:55945 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbaAGPuA (ORCPT ); Tue, 7 Jan 2014 10:50:00 -0500 Date: Tue, 7 Jan 2014 07:49:35 -0800 From: Christoph Hellwig To: Jan Kara Cc: "Darrick J. Wong" , Aurelien Jarno , "Theodore Ts'o" , Alexander Viro , Rob Browning , Dave Chinner , Miklos Szeredi , linux-fsdevel , linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [RFC PATCH] fs: xattr-based FS_IOC_[GS]ETFLAGS interface Message-ID: <20140107154935.GA17609@infradead.org> References: <20140107025855.GA9229@birch.djwong.org> <20140107124831.GD16640@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140107124831.GD16640@quack.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2014 at 01:48:31PM +0100, Jan Kara wrote: > I have to say I'm not thrilled by the idea of juggling strings in > userspace and in kernel to set a flag for an inode... Nevermind the massive amounts of code that sit in the filesystem. Although my recent ACL patches are the first step towards handling the existing semantically overloaded xattrs in common code. Unless Al has a valid reason to disagree I'd like to put a big NAK on adding any new xattrs that aren't stored on disk as-is but provide magic functionality, as they are pain to implement, maintain, and audit.