Re: [PATCH 3.12 000/118] 3.12.6-stable review

Greg Kroah-Hartman
2013-12-19T03:20:35Z

On Wed, Dec 18, 2013 at 07:00:22PM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 18, 2013 at 06:56:58PM -0800, Greg Kroah-Hartman wrote:
> > On Wed, Dec 18, 2013 at 03:48:57PM -0800, Guenter Roeck wrote:
> > > On Wed, Dec 18, 2013 at 01:10:37PM -0800, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 3.12.6 release.
> > > > There are 118 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Fri Dec 20 21:12:03 UTC 2013.
> > > > Anything received after that time might be too late.
> > > >
> > >
> > > Hi greg,
> > >
> > > I see a couple of failed builds.
> > >
> > > m68k:allmodconfig ... failed
> > > mips:allmodconfig ... failed
> > > sparc64:allmodconfig ... failed
> > > x86_64:allyesconfig ... failed
> > > x86_64:allmodconfig ... failed
> > >
> > > Build is still going on, so there may be more.
> > >
> > > Error log:
> > >
> > > drivers/staging/comedi/drivers/ssv_dnp.c: In function 'dnp_dio_insn_bits':
> > > drivers/staging/comedi/drivers/ssv_dnp.c:63:2: error: implicit declaration of function 'comedi_dio_update_state' [-Werror=implicit-function-declaration]
> > > cc1: some warnings being treated as errors
> > > make[4]: *** [drivers/staging/comedi/drivers/ssv_dnp.o] Error 1
> > >
> > > Function comedi_dio_update_state() is not defined anywhere in 3.12,
> > > so patches
> > > staging: comedi: ssv_dnp: use comedi_dio_update_state()
> > > staging: comedi: drivers: use comedi_dio_update_state() for simple cases
> > >
> > > won't apply without additional changes.
> >
> > Odd, let me see what happened, as I thought this was building properly
> > on my test boxes...
>
> Ah, I didn't have COMPILE_TEST enabled, now I see the problem, my fault,
> I'll go fix this up now...

Ok, found this, it was my fault, I tried to take more of one of Ian's
patches than what he had actually sent me. I'll do a -rc2 in a few
minutes, thanks so much for the build testing.

greg k-h