From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754730AbaAGWx4 (ORCPT ); Tue, 7 Jan 2014 17:53:56 -0500 Received: from 8bytes.org ([85.214.48.195]:37082 "EHLO mail.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754136AbaAGWxr (ORCPT ); Tue, 7 Jan 2014 17:53:47 -0500 Date: Tue, 7 Jan 2014 23:53:45 +0100 From: Joerg Roedel To: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Rob Clark Subject: Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU Message-ID: <20140107225345.GE29041@8bytes.org> References: <1389134846-1000-1-git-send-email-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1389134846-1000-1-git-send-email-joro@8bytes.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Tue Jan 7 23:53:46 2014 X-DSPAM-Confidence: 0.9991 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 52cc857a20861814481943 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: > The DRM driver for MSM depends on symbols from the MSM > IOMMU driver. Add this dependency to the Kconfig file. > > Fixes this comile error: > > Kernel: arch/arm/boot/zImage is ready > ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko] > undefined! > make[2]: *** [__modpost] Error 1 > > Cc: Rob Clark > Signed-off-by: Joerg Roedel > --- > drivers/gpu/drm/msm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > index f39ab75..d3de8e1 100644 > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -4,6 +4,7 @@ config DRM_MSM > depends on DRM > depends on ARCH_MSM > depends on ARCH_MSM8960 > + depends on MSM_IOMMU > select DRM_KMS_HELPER > select SHMEM > select TMPFS FYI, I put the patch to my arm/msm branch meanwhile to get the build error fixed. Please let me know when there is another solution merged and I will drop it. Joerg