From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marius Silaghi <msilaghi@fit.edu>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Lan Tianyu <tianyu.lan@intel.com>,
Xenia Ragiadakou <burzalodowa@gmail.com>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH] usbcore: fix BABBLE failed enumeration of legacy USB2 devices on USB3 bus
Date: Tue, 7 Jan 2014 16:32:37 -0800 [thread overview]
Message-ID: <20140108003237.GF13062@kroah.com> (raw)
In-Reply-To: <02270BA454DB7548ABE8E2EBF31D46D96FC7B4C5@EX10-BE1.fit.edu>
On Tue, Dec 24, 2013 at 04:19:18AM +0000, Marius Silaghi wrote:
> From: Marius C Silaghi <msilaghi@fit.edu>
>
> This patch is generated against the last kernel version in the github kernel repository.
We work off of the git.kernel.org trees, not github :)
> Some older families of USB2 cameras (STC-XXXXXUSB) do not support querying only the first 8 bytes of their
> device descriptor and therefore fail at enumeration on USB3 HCDs, with babble error -75 as they send more than
> the expected 8 bytes. The proposed patch extends the mechanism used for non USB3 HCDs in the first part of
> the same function, and successively tries to query both the 8 byte prefix of the device descriptor, as well as
> the whole device descriptor (in case the old style query of the 8 byte prefix fails).
> In fact, for the cameras I try to fix, the preferred condition is the negation of the one in the proposed patch,
> "if (!USE_NEW_SCHEME(retry_counter))", to try first the version successful on this case, but I keep the
> current order of the "if" branches to ensure clean continuation of support for other supported devices.
>
> Signed-off-by: Marius C Silaghi <msilaghi@fit.edu>
I'll let Sarah take this patch, if it passes her testing.
thanks,
greg k-h
next prev parent reply other threads:[~2014-01-08 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 4:19 [PATCH] usbcore: fix BABBLE failed enumeration of legacy USB2 devices on USB3 bus Marius Silaghi
2014-01-08 0:32 ` Greg Kroah-Hartman [this message]
2014-01-08 4:00 ` Marius Silaghi
2014-01-18 4:18 ` Jérôme Carretero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108003237.GF13062@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=burzalodowa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=msilaghi@fit.edu \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tianyu.lan@intel.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox