public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: stern@rowland.harvard.edu, sarah.a.sharp@linux.intel.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	jianqian <jianqiang.tang@intel.com>
Subject: Re: [RFC/PATCH] usb/xhci: avoid kernel panic on xhci_suspend()
Date: Tue, 7 Jan 2014 17:46:39 -0800	[thread overview]
Message-ID: <20140108014639.GB7823@kroah.com> (raw)
In-Reply-To: <1389145466-8302-1-git-send-email-david.a.cohen@linux.intel.com>

On Tue, Jan 07, 2014 at 05:44:26PM -0800, David Cohen wrote:
> From: jianqian <jianqiang.tang@intel.com>
> 
> There is a possible kernel panic faced on xhci_suspend().
> Due to kernel modified the hub autosupend_delay to 0s, after usb1 root
> hub finishes initialization, it will trigger runtime_suspend and then
> it will trigger xhci runtime suspend. But at that time, if
> xhci->shared_hcd is still doing initialization, it is possible to face
> null pointer kernel panic in xhci_suspend() function.
> 
> This patch checks if xhci->shared_hcd is null to avoid panic.
> 
> Signed-off-by: jianqian <jianqiang.tang@intel.com>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
> 
> This is the kernel panic. The bug was discovered on current LTS kernel 3.10, as
> showed on logs. But the problem does not seem to be fixed so far.
> Maybe we should consider apply it on kernel >= 3.10?

How do you trigger this?  I've never seen anyone report this problem
before, is there something different in the hardware you are using that
enables this to be triggered easier?

thanks,

greg k-h

  parent reply	other threads:[~2014-01-08  1:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08  1:44 [RFC/PATCH] usb/xhci: avoid kernel panic on xhci_suspend() David Cohen
2014-01-08  1:45 ` Greg KH
2014-01-08 15:48   ` Alan Stern
2014-01-08 19:53     ` David Cohen
2014-02-21 13:29       ` Mathias Nyman
2014-01-08  1:46 ` Greg KH [this message]
2014-01-08  3:49   ` Tang, Jianqiang
2014-01-08  4:16     ` Greg KH
2014-01-08  5:45       ` David Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140108014639.GB7823@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=david.a.cohen@linux.intel.com \
    --cc=jianqiang.tang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox