* [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning
@ 2014-01-08 10:13 Wei Yongjun
2014-01-08 10:14 ` Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wei Yongjun @ 2014-01-08 10:13 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, linus.walleij, fabio.baltieri,
lee.jones, arnd
Cc: yongjun_wei, alsa-devel, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warning:
sound/soc/ux500/ux500_msp_i2s.c:649:5: warning:
symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
sound/soc/ux500/ux500_msp_i2s.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 7f2a4ac..959d7b4 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -646,9 +646,9 @@ int ux500_msp_i2s_close(struct ux500_msp *msp, unsigned int dir)
}
-int ux500_msp_i2s_of_init_msp(struct platform_device *pdev,
- struct ux500_msp *msp,
- struct msp_i2s_platform_data **platform_data)
+static int ux500_msp_i2s_of_init_msp(struct platform_device *pdev,
+ struct ux500_msp *msp,
+ struct msp_i2s_platform_data **platform_data)
{
struct msp_i2s_platform_data *pdata;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning
2014-01-08 10:13 [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning Wei Yongjun
@ 2014-01-08 10:14 ` Arnd Bergmann
2014-01-08 10:17 ` Linus Walleij
2014-01-08 12:22 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2014-01-08 10:14 UTC (permalink / raw)
To: Wei Yongjun
Cc: lgirdwood, broonie, perex, tiwai, linus.walleij, fabio.baltieri,
lee.jones, yongjun_wei, alsa-devel, linux-kernel
On Wednesday 08 January 2014 18:13:35 Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warning:
>
> sound/soc/ux500/ux500_msp_i2s.c:649:5: warning:
> symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning
2014-01-08 10:13 [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning Wei Yongjun
2014-01-08 10:14 ` Arnd Bergmann
@ 2014-01-08 10:17 ` Linus Walleij
2014-01-08 11:06 ` Lee Jones
2014-01-08 12:22 ` Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2014-01-08 10:17 UTC (permalink / raw)
To: Wei Yongjun, Lee Jones
Cc: Liam Girdwood, Mark Brown, perex@perex.cz, Takashi Iwai,
Fabio Baltieri, Arnd Bergmann, Wei Yongjun,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
On Wed, Jan 8, 2014 at 11:13 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warning:
>
> sound/soc/ux500/ux500_msp_i2s.c:649:5: warning:
> symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Lee, is this something that needs to go along with your patches to
ASoC or can I apply this separately?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning
2014-01-08 10:17 ` Linus Walleij
@ 2014-01-08 11:06 ` Lee Jones
2014-01-08 11:58 ` Linus Walleij
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2014-01-08 11:06 UTC (permalink / raw)
To: Linus Walleij
Cc: Wei Yongjun, Liam Girdwood, Mark Brown, perex@perex.cz,
Takashi Iwai, Fabio Baltieri, Arnd Bergmann, Wei Yongjun,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
On Wed, 08 Jan 2014, Linus Walleij wrote:
> On Wed, Jan 8, 2014 at 11:13 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > Fixes the following sparse warning:
> >
> > sound/soc/ux500/ux500_msp_i2s.c:649:5: warning:
> > symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
FWIW: Acked-by: Lee Jones <lee.jones@linaro.org>
> Lee, is this something that needs to go along with your patches to
> ASoC or can I apply this separately?
If Mark takes it, then it will just apply as my patches have already
been applied.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning
2014-01-08 11:06 ` Lee Jones
@ 2014-01-08 11:58 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2014-01-08 11:58 UTC (permalink / raw)
To: Lee Jones, Mark Brown
Cc: Wei Yongjun, Liam Girdwood, perex@perex.cz, Takashi Iwai,
Fabio Baltieri, Arnd Bergmann, Wei Yongjun,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
On Wed, Jan 8, 2014 at 12:06 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Wed, 08 Jan 2014, Linus Walleij wrote:
>
>> On Wed, Jan 8, 2014 at 11:13 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>> >
>> > Fixes the following sparse warning:
>> >
>> > sound/soc/ux500/ux500_msp_i2s.c:649:5: warning:
>> > symbol 'ux500_msp_i2s_of_init_msp' was not declared. Should it be static?
>> >
>> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> FWIW: Acked-by: Lee Jones <lee.jones@linaro.org>
>
>> Lee, is this something that needs to go along with your patches to
>> ASoC or can I apply this separately?
>
> If Mark takes it, then it will just apply as my patches have already
> been applied.
Mark can you take this patch to minimize the fuzz?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning
2014-01-08 10:13 [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning Wei Yongjun
2014-01-08 10:14 ` Arnd Bergmann
2014-01-08 10:17 ` Linus Walleij
@ 2014-01-08 12:22 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-01-08 12:22 UTC (permalink / raw)
To: Wei Yongjun
Cc: lgirdwood, perex, tiwai, linus.walleij, fabio.baltieri, lee.jones,
arnd, yongjun_wei, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
On Wed, Jan 08, 2014 at 06:13:35PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warning:
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-08 12:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-08 10:13 [PATCH -next] ASoC: ux500: Fix sparse non static symbol warning Wei Yongjun
2014-01-08 10:14 ` Arnd Bergmann
2014-01-08 10:17 ` Linus Walleij
2014-01-08 11:06 ` Lee Jones
2014-01-08 11:58 ` Linus Walleij
2014-01-08 12:22 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox