From: Mark Brown <broonie@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
lee.jones@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com,
sameo@linux.intel.com, sbkim73@samsung.com, patches@linaro.org
Subject: Re: [PATCH 2/3] regulator: Add support for S2MPA01 regulator
Date: Wed, 8 Jan 2014 12:30:02 +0000 [thread overview]
Message-ID: <20140108123002.GY31886@sirena.org.uk> (raw)
In-Reply-To: <1389162390-4582-2-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Wed, Jan 08, 2014 at 11:56:29AM +0530, Sachin Kamat wrote:
> + if (!iodev->dev->of_node) {
> + if (pdata) {
> + goto common_reg;
> + } else {
> + dev_err(pdev->dev.parent,
> + "Platform data or DT node not supplied\n");
> + return -ENODEV;
> + }
> + }
The driver shouldn't need these to probe, it should be able to start in
read only mode with no configuration.
> +static int __init s2mpa01_pmic_init(void)
> +{
> + return platform_driver_register(&s2mpa01_pmic_driver);
> +}
> +subsys_initcall(s2mpa01_pmic_init);
module_platform_driver().
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-08 12:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 6:26 [PATCH 1/3] mfd: Add support for S2MPA01 device Sachin Kamat
2014-01-08 6:26 ` [PATCH 2/3] regulator: Add support for S2MPA01 regulator Sachin Kamat
2014-01-08 12:30 ` Mark Brown [this message]
2014-01-09 5:09 ` Sachin Kamat
2014-01-09 10:34 ` Mark Brown
2014-01-08 6:26 ` [PATCH 3/3] Documentation: mfd: Add binding document for S2MPA01 Sachin Kamat
2014-01-08 9:41 ` Mark Rutland
2014-01-09 4:47 ` Sachin Kamat
2014-01-08 9:02 ` [PATCH 1/3] mfd: Add support for S2MPA01 device Lee Jones
2014-01-08 9:21 ` Sachin Kamat
2014-01-08 9:27 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108123002.GY31886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox