Re: [PATCH] [SCSI] advansys: change buildtime warning into runtime error

[Ondrej Zary <linux@rainbow-software.org>]

On Wednesday 08 January 2014 21:05:14 Paul Bolle wrote:
> On Tue, 2013-01-29 at 11:20 +0100, Paul Bolle wrote:
> > On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
> > > Building advansys.o triggers this warning:
> > >     drivers/scsi/advansys.c:71:2: warning: #warning this driver is
> > > still not properly converted to the DMA API [-Wcpp]
> > >
> > > This warning can be traced back to a patch called "advansys: add
> > > warning and convert #includes" which was included in v2.6.10. That
> > > patch also marked the driver as BROKEN.
> > >
> > > Commit 4661e3eace2c7b8433476b5bf0ee437ab3c7dfd4 ("[SCSI] advansys
> > > driver: limp along on x86") enabled this driver for x86-32. And commit
> > > 9d511a4b29de6764931343d03e493f2e04df0271 ("[SCSI] advansys: Changes to
> > > work on parisc") enabled this driver for all architectures. But the
> > > commit explanation stated:
> > >     I haven't removed the #warning yet because virt_to_bus/bus_to_virt
> > > are only eliminated for narrow boards.  Wide boards need more work.
> > >
> > > Five years have passed and, apparently, those wide boards still need
> > > more work. So let's change the buildtime warning into a runtime error,
> > > only printed for those wide boards. Perhaps that might push the people
> > > using those wide boards to convert this driver. And for all others
> > > there's now one less buildtime warning to ignore.
> > >
> > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > > ---
> > > Compile tested only. I don't have any AdvanSys SCSI boards (neither
> > > narrow nor wide).
> >
> > The date of this message suggests I submitted this patch for a warning
> > seen while building v3.7-rc4. An identical warning can be seen while
> > building v3.8-rc5. What's the status of my patch? Did anyone find some
> > time to have a look at it?
>
> I've been carrying this patch locally for over a year. Is there any
> chance of someone trying to remove this buildtime warning?
>
> I'm inclined to submit a path to Fedora - my local builds use
> their .config as a base - to just disable this driver. It seems that
> would increase my chances of finally shutting down this warning.
>
>
> Paul Bolle

The driver works fine with narrow boards. Please don't break working drivers 
because of some stupid warning.

-- 
Ondrej Zary