[PATCH] [SCSI] advansys: change buildtime warning into runtime error

[PATCH] [SCSI] advansys: change buildtime warning into runtime error

[Paul Bolle]

Building advansys.o triggers this warning:
    drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API [-Wcpp]

This warning can be traced back to a patch called "advansys: add warning
and convert #includes" which was included in v2.6.10. That patch also
marked the driver as BROKEN.

Commit 4661e3eace2c7b8433476b5bf0ee437ab3c7dfd4 ("[SCSI] advansys
driver: limp along on x86") enabled this driver for x86-32. And commit
9d511a4b29de6764931343d03e493f2e04df0271 ("[SCSI] advansys: Changes to
work on parisc") enabled this driver for all architectures. But the
commit explanation stated:
    I haven't removed the #warning yet because virt_to_bus/bus_to_virt are
    only eliminated for narrow boards.  Wide boards need more work.

Five years have passed and, apparently, those wide boards still need
more work. So let's change the buildtime warning into a runtime error,
only printed for those wide boards. Perhaps that might push the people
using those wide boards to convert this driver. And for all others
there's now one less buildtime warning to ignore.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Compile tested only. I don't have any AdvanSys SCSI boards (neither
narrow nor wide).

 drivers/scsi/advansys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 374c4ed..23d347d 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -68,7 +68,6 @@
  *  7. advansys_info is not safe against multiple simultaneous callers
  *  8. Add module_param to override ISA/VLB ioport array
  */
-#warning this driver is still not properly converted to the DMA API
 
 /* Enable driver /proc statistics. */
 #define ADVANSYS_STATS
@@ -12772,6 +12771,7 @@ advansys_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	    pdev->device == PCI_DEVICE_ID_38C0800_REV1 ||
 	    pdev->device == PCI_DEVICE_ID_38C1600_REV1) {
 		board->flags |= ASC_IS_WIDE_BOARD;
+		pr_err("This driver is still not properly converted to the DMA API");
 	}
 
 	err = advansys_board_found(shost, ioport, ASC_IS_PCI);
-- 
1.7.11.7

Re: [PATCH] [SCSI] advansys: change buildtime warning into runtime error

[Paul Bolle]

On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
> Building advansys.o triggers this warning:
>     drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API [-Wcpp]
> 
> This warning can be traced back to a patch called "advansys: add warning
> and convert #includes" which was included in v2.6.10. That patch also
> marked the driver as BROKEN.
> 
> Commit 4661e3eace2c7b8433476b5bf0ee437ab3c7dfd4 ("[SCSI] advansys
> driver: limp along on x86") enabled this driver for x86-32. And commit
> 9d511a4b29de6764931343d03e493f2e04df0271 ("[SCSI] advansys: Changes to
> work on parisc") enabled this driver for all architectures. But the
> commit explanation stated:
>     I haven't removed the #warning yet because virt_to_bus/bus_to_virt are
>     only eliminated for narrow boards.  Wide boards need more work.
> 
> Five years have passed and, apparently, those wide boards still need
> more work. So let's change the buildtime warning into a runtime error,
> only printed for those wide boards. Perhaps that might push the people
> using those wide boards to convert this driver. And for all others
> there's now one less buildtime warning to ignore.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Compile tested only. I don't have any AdvanSys SCSI boards (neither
> narrow nor wide).

The date of this message suggests I submitted this patch for a warning
seen while building v3.7-rc4. An identical warning can be seen while
building v3.8-rc5. What's the status of my patch? Did anyone find some
time to have a look at it?


Paul Bolle

Re: [PATCH] [SCSI] advansys: change buildtime warning into runtime error

[Paul Bolle]

On Tue, 2013-01-29 at 11:20 +0100, Paul Bolle wrote:
> On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
> > Building advansys.o triggers this warning:
> >     drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API [-Wcpp]
> > 
> > This warning can be traced back to a patch called "advansys: add warning
> > and convert #includes" which was included in v2.6.10. That patch also
> > marked the driver as BROKEN.
> > 
> > Commit 4661e3eace2c7b8433476b5bf0ee437ab3c7dfd4 ("[SCSI] advansys
> > driver: limp along on x86") enabled this driver for x86-32. And commit
> > 9d511a4b29de6764931343d03e493f2e04df0271 ("[SCSI] advansys: Changes to
> > work on parisc") enabled this driver for all architectures. But the
> > commit explanation stated:
> >     I haven't removed the #warning yet because virt_to_bus/bus_to_virt are
> >     only eliminated for narrow boards.  Wide boards need more work.
> > 
> > Five years have passed and, apparently, those wide boards still need
> > more work. So let's change the buildtime warning into a runtime error,
> > only printed for those wide boards. Perhaps that might push the people
> > using those wide boards to convert this driver. And for all others
> > there's now one less buildtime warning to ignore.
> > 
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Compile tested only. I don't have any AdvanSys SCSI boards (neither
> > narrow nor wide).
> 
> The date of this message suggests I submitted this patch for a warning
> seen while building v3.7-rc4. An identical warning can be seen while
> building v3.8-rc5. What's the status of my patch? Did anyone find some
> time to have a look at it?

I've been carrying this patch locally for over a year. Is there any
chance of someone trying to remove this buildtime warning?

I'm inclined to submit a path to Fedora - my local builds use
their .config as a base - to just disable this driver. It seems that
would increase my chances of finally shutting down this warning.


Paul Bolle

Re: [PATCH] [SCSI] advansys: change buildtime warning into runtime error

[Ondrej Zary]

On Wednesday 08 January 2014 21:05:14 Paul Bolle wrote:
> On Tue, 2013-01-29 at 11:20 +0100, Paul Bolle wrote:
> > On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
> > > Building advansys.o triggers this warning:
> > >     drivers/scsi/advansys.c:71:2: warning: #warning this driver is
> > > still not properly converted to the DMA API [-Wcpp]
> > >
> > > This warning can be traced back to a patch called "advansys: add
> > > warning and convert #includes" which was included in v2.6.10. That
> > > patch also marked the driver as BROKEN.
> > >
> > > Commit 4661e3eace2c7b8433476b5bf0ee437ab3c7dfd4 ("[SCSI] advansys
> > > driver: limp along on x86") enabled this driver for x86-32. And commit
> > > 9d511a4b29de6764931343d03e493f2e04df0271 ("[SCSI] advansys: Changes to
> > > work on parisc") enabled this driver for all architectures. But the
> > > commit explanation stated:
> > >     I haven't removed the #warning yet because virt_to_bus/bus_to_virt
> > > are only eliminated for narrow boards.  Wide boards need more work.
> > >
> > > Five years have passed and, apparently, those wide boards still need
> > > more work. So let's change the buildtime warning into a runtime error,
> > > only printed for those wide boards. Perhaps that might push the people
> > > using those wide boards to convert this driver. And for all others
> > > there's now one less buildtime warning to ignore.
> > >
> > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > > ---
> > > Compile tested only. I don't have any AdvanSys SCSI boards (neither
> > > narrow nor wide).
> >
> > The date of this message suggests I submitted this patch for a warning
> > seen while building v3.7-rc4. An identical warning can be seen while
> > building v3.8-rc5. What's the status of my patch? Did anyone find some
> > time to have a look at it?
>
> I've been carrying this patch locally for over a year. Is there any
> chance of someone trying to remove this buildtime warning?
>
> I'm inclined to submit a path to Fedora - my local builds use
> their .config as a base - to just disable this driver. It seems that
> would increase my chances of finally shutting down this warning.
>
>
> Paul Bolle

The driver works fine with narrow boards. Please don't break working drivers 
because of some stupid warning.

-- 
Ondrej Zary

Re: [PATCH] [SCSI] advansys: change buildtime warning into runtime error

[Paul Bolle]

On Wed, 2014-01-08 at 21:15 +0100, Ondrej Zary wrote:
> The driver works fine with narrow boards. Please don't break working drivers 
> because of some stupid warning.

My patch changed a buildtime warning for both narrow and wide boards in
a runtime error on wide boards only. That wouldn't break the narrow
boards. (I happen to own neither a narrow nor a wide board.)

In seven years that buildtime warning has not resulted in a fix for wide
boards, has it? So at this point that warning is rather pointless.

Is anybody even using these wide boards?


Paul Bolle