From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: MonamAgarwal <monamagarwal123@gmail.com>,
devel@driverdev.osuosl.org, andreas.dilger@intel.com,
peter.p.waskiewicz.jr@intel.com, linux-kernel@vger.kernel.org,
rashika.kheria@gmail.com
Subject: Re: [PATCH 1/2] Staging: lustre: Fix line length exceeding 80 characters
Date: Wed, 8 Jan 2014 15:55:22 -0800 [thread overview]
Message-ID: <20140108235522.GB20259@kroah.com> (raw)
In-Reply-To: <1388953851.5808.31.camel@joe-AO722>
On Sun, Jan 05, 2014 at 12:30:51PM -0800, Joe Perches wrote:
> On Mon, 2014-01-06 at 01:41 +0530, MonamAgarwal wrote:
> > This patch fixes the following checkpatch.pl warning in
> > lustre/ldlm/interval_tree.c
> > WARNING: line over 80 characters in the file
> []
> > diff --git a/drivers/staging/lustre/lustre/ldlm/interval_tree.c b/drivers/staging/lustre/lustre/ldlm/interval_tree.c
> []
> > @@ -429,7 +429,8 @@ static void interval_erase_color(struct interval_node *node,
> > struct interval_node *o_left;
> > o_left = tmp->in_left;
> > if (o_left)
> > - o_left->in_color = INTERVAL_BLACK;
> > + o_left->in_color =
> > + INTERVAL_BLACK;
>
> Likely this function would be better off with some
> refactoring instead of straining to fit 80 cols.
I agree, if you are doing things like this, that's a huge hint that the
code needs fixing.
thanks,
greg k-h
next prev parent reply other threads:[~2014-01-08 23:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 20:11 [PATCH 1/2] Staging: lustre: Fix line length exceeding 80 characters MonamAgarwal
2014-01-05 20:30 ` Joe Perches
2014-01-08 23:55 ` Greg KH [this message]
2014-01-11 11:00 ` [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c Monam Agarwal
2014-01-11 11:19 ` Dan Carpenter
2014-01-11 11:26 ` Monam Agarwal
2014-01-11 11:39 ` Dan Carpenter
2014-01-11 11:44 ` Monam Agarwal
2014-01-11 20:33 ` Greg KH
[not found] ` <0E07CEA6-D544-4809-A0DC-48DCB808669D@intel.com>
2014-01-14 8:01 ` Xiong, Jinshan
2014-01-14 11:09 ` Monam Agarwal
2014-01-14 17:41 ` Xiong, Jinshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108235522.GB20259@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox