From: Mark Brown <broonie@kernel.org>
To: Trent Piepho <tpiepho@gmail.com>
Cc: Daniel Matuschek <daniel@matuschek.net>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Dimitris.Papastamos@wolfsonmicro.com,
Takashi Iwai <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree-discuss@lists.ozlabs.org,
patches@opensource.wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: wm8804: Allow fine-grained control of the PLL generation
Date: Thu, 9 Jan 2014 17:23:50 +0000 [thread overview]
Message-ID: <20140109172350.GD12858@sirena.org.uk> (raw)
In-Reply-To: <CA+7tXijibZKUoeqeqpvOhgJg17OgpYR2Kv5S17TFdAKvaCjt3g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On Thu, Jan 09, 2014 at 09:14:07AM -0800, Trent Piepho wrote:
> On Thu, Jan 9, 2014 at 7:29 AM, Daniel Matuschek <daniel@matuschek.net> wrote:
Daniel, please take more care with the CC lists when posting things -
there's nothing to do with device tree in this patch but you've CCed the
DT list and some DT people wich means more noise in their mailbox.
> Why does it need to be an option? If 256x is better, then why not
> always use it? Maybe the code to select the divisor should be better?
It's typically a power/performance tradeoff, though for this part I
can't see anyone caring about power.
> Since it stops at the first divisor that works, won't it always use
> mclkdiv=1? If mclkdiv=0 is better, why not just list those first/only
> in the table so they get used?
This seems like the best idea. I suspect the table just got typed in
from the datasheet.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-01-09 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 21:36 [PATCH] ASoC: wm8804: Allow fine-grained control of the PLL generation Daniel Matuschek
2014-01-09 14:20 ` Mark Brown
2014-01-09 14:27 ` [alsa-devel] " Charles Keepax
2014-01-09 15:29 ` Daniel Matuschek
2014-01-09 17:14 ` Trent Piepho
2014-01-09 17:23 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109172350.GD12858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Dimitris.Papastamos@wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=daniel@matuschek.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rob.herring@calxeda.com \
--cc=tiwai@suse.de \
--cc=tpiepho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox