From: Lee Jones <lee.jones@linaro.org>
To: Laszlo Papp <lpapp@kde.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Linus Walleij <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mfd: MAX6650/6651 support
Date: Fri, 10 Jan 2014 09:56:48 +0000 [thread overview]
Message-ID: <20140110095648.GA28141@lee--X1> (raw)
In-Reply-To: <CAOMwXhPhOGn2n2ca1aenxS_-b0pYiZ_KvX7bR666MsoxaQeL9g@mail.gmail.com>
On Thu, 09 Jan 2014, Laszlo Papp wrote:
> >> +int max6651_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
> >> +{
> >
> > Probably best to use Regmap instead.
> >
> > regmap_i2c_read()
>
> >> +int max6651_write_reg(struct i2c_client *i2c, u8 reg, u8 value)
> >> +{
> >> + struct max6651_dev *max6651 = i2c_get_clientdata(i2c);
> >> + int ret;
> >
> > Same here.
> >
> > regmap_i2c_write()
>
> Hmm, but what Linus linked is using regmap_read/write(...) instead of
> regmap_i2c_read/write(...).
>
> I thought I would need to be using the former. Perhaps, I
> misunderstand something?
>
> I do not even find the aforementioend functions used by drivers based
> on this LXR result:
> http://lxr.free-electrons.com/ident?i=regmap_i2c_write
Linus is in a better position to know, use his suggestion.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-01-10 9:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 16:08 [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs Laszlo Papp
2013-12-23 16:08 ` [PATCH 1/3] mfd: MAX6650/6651 support Laszlo Papp
2014-01-07 14:11 ` Linus Walleij
2014-01-08 14:39 ` Laszlo Papp
2014-01-08 22:39 ` Lee Jones
2014-01-09 2:15 ` Laszlo Papp
2014-01-09 9:41 ` Lee Jones
2014-01-09 10:33 ` Laszlo Papp
2014-01-09 11:06 ` Lee Jones
2014-01-09 11:11 ` Laszlo Papp
2014-01-09 11:21 ` Lee Jones
2014-01-09 14:43 ` Laszlo Papp
2014-01-10 9:56 ` Lee Jones [this message]
2014-01-15 8:02 ` Linus Walleij
2013-12-23 16:08 ` [PATCH 2/3] hwmon: (max6650) Convert to be a platform driver Laszlo Papp
2014-02-13 17:41 ` Laszlo Papp
2014-02-14 9:20 ` Lee Jones
2013-12-23 16:08 ` [PATCH 3/3] gpio: MAX6650/6651 support Laszlo Papp
2014-01-07 14:33 ` Linus Walleij
2014-01-08 14:59 ` Laszlo Papp
2014-01-13 9:22 ` Laszlo Papp
2014-01-13 9:48 ` Linus Walleij
2014-01-13 12:15 ` Laszlo Papp
2014-01-13 9:43 ` Linus Walleij
2014-01-13 12:12 ` Laszlo Papp
2014-01-14 17:17 ` Laszlo Papp
2014-01-15 10:05 ` Linus Walleij
2014-01-15 10:51 ` Laszlo Papp
2014-01-15 12:21 ` Linus Walleij
2014-01-07 9:09 ` [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs Lee Jones
2014-01-08 14:37 ` Laszlo Papp
2014-01-08 17:07 ` Laszlo Papp
2014-01-08 17:22 ` Lee Jones
2014-01-08 17:31 ` Laszlo Papp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110095648.GA28141@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lpapp@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).