From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Caz Yokoyama <Caz.Yokoyama@intel.com>,
Dasaratharaman Chandramouli
<dasaratharaman.chandramouli@intel.com>,
Nikhil Rao <nikhil.rao@intel.com>,
Harshavardhan R Kharche <harshavardhan.r.kharche@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Intel MIC host driver: possible signed underflow (undefined behavior) in userspace API
Date: Fri, 10 Jan 2014 12:43:54 -0800 [thread overview]
Message-ID: <20140110204354.GD10235@kroah.com> (raw)
In-Reply-To: <1389378175.83628.14.camel@localhost>
On Fri, Jan 10, 2014 at 10:22:55AM -0800, Sudeep Dutt wrote:
> On Fri, 2014-01-10 at 06:21 -0800, Greg Kroah-Hartman wrote:
> > On Fri, Jan 10, 2014 at 05:56:25AM +0000, Mathieu Desnoyers wrote:
> > > Hi,
> > >
> > > Looking at this commit:
> > >
> > > commit f69bcbf3b4c4b333dcd7a48eaf868bf0c88edab5
> > > Author: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > > Date: Thu Sep 5 16:42:18 2013 -0700
> > >
> > > Intel MIC Host Driver Changes for Virtio Devices.
> > >
> > > Especially at:
> > >
> > > +struct mic_copy_desc {
> > > +#ifdef __KERNEL__
> > > + struct iovec __user *iov;
> > > +#else
> > > + struct iovec *iov;
> > > +#endif
> > > + int iovcnt;
> > > + __u8 vr_idx;
> > > + __u8 update_used;
> > > + __u32 out_len;
> > > +};
Oh, there's also the obvious 32/64 bit userspace/kernel issue here as
well, but I'm sure you all know how to handle that properly. It would
be nice to fix that up, if you can change the ABI still.
thanks,
greg k-h
prev parent reply other threads:[~2014-01-10 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1151498255.5788.1389332631491.JavaMail.zimbra@efficios.com>
2014-01-10 5:56 ` Intel MIC host driver: possible signed underflow (undefined behavior) in userspace API Mathieu Desnoyers
2014-01-10 14:21 ` Greg Kroah-Hartman
2014-01-10 18:22 ` Sudeep Dutt
2014-01-10 20:43 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140110204354.GD10235@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Caz.Yokoyama@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=dasaratharaman.chandramouli@intel.com \
--cc=harshavardhan.r.kharche@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=nikhil.rao@intel.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox