From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752360AbaAKLkV (ORCPT ); Sat, 11 Jan 2014 06:40:21 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:36738 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbaAKLkS (ORCPT ); Sat, 11 Jan 2014 06:40:18 -0500 Date: Sat, 11 Jan 2014 14:39:59 +0300 From: Dan Carpenter To: Monam Agarwal Cc: devel@driverdev.osuosl.org, andreas.dilger@intel.com, gregkh@linuxfoundation.org, peter.p.waskiewicz.jr@intel.com, linux-kernel@vger.kernel.org, Rashika Kheria Subject: Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c Message-ID: <20140111113959.GW30234@mwanda> References: <52c9bc8b.ca41420a.775b.ffff98ce@mx.google.com> <1389438033-5928-1-git-send-email-monamagarwal123@gmail.com> <20140111111931.GV30234@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 11, 2014 at 04:56:44PM +0530, Monam Agarwal wrote: > I took n as a flag to decide whether parent->in_left == node is true > or not in the called function. So "n" stands for "node"? > Should I use some other name for the flag. Yes. regards, dan carpenter