From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: dri-devel@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>,
Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting
Date: Sat, 11 Jan 2014 18:36:48 +0000 [thread overview]
Message-ID: <20140111183648.GH15937@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140109120607.6a33bee5@armhf>
On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote:
> According to the comment, the TBG_CNTRL_0 register must be set at the
> end of the mode change sequence.
So you believe comments without understanding the history, and you move
code around due to those.
No, this is again wrong. That write to REG_TBG_CNTRL_0 in the sequence
writing the video information to the chip. This doesn't encompass the
HDMI/DVI mode setting nor the audio configuration - the audio configuration
can change independently of the video setting, and does not require this
register to be written.
This also brings up a bug in one of your previous patches which I now
must go back and comment upon.
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
next prev parent reply other threads:[~2014-01-11 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 11:06 [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting Jean-Francois Moine
2014-01-11 18:36 ` Russell King - ARM Linux [this message]
2014-01-12 12:23 ` Jean-Francois Moine
2014-01-12 12:31 ` Russell King - ARM Linux
2014-01-12 13:20 ` Jean-Francois Moine
2014-01-12 13:38 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140111183648.GH15937@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox