From: Vinod Koul <vinod.koul@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Mike Frysinger <vapier@gentoo.org>,
uclinux-dist-devel@blackfin.uclinux.org,
LKML <linux-kernel@vger.kernel.org>,
dmaengine@vger.kernel.org
Subject: Re: blackfin + dmaengine: conflicting define/enum "DMA_COMPLETE"
Date: Mon, 13 Jan 2014 13:39:07 +0530 [thread overview]
Message-ID: <20140113080907.GB25466@intel.com> (raw)
In-Reply-To: <52D18DE4.2020008@infradead.org>
On Sat, Jan 11, 2014 at 10:31:00AM -0800, Randy Dunlap wrote:
> On 01/11/2014 10:09 AM, Marc Kleine-Budde wrote:
> > Hello,
> >
> > in current linux-next (and net-next) the compilation of the CAN
> > drivers[1] with ARCH=blackfin fails with:
> >
> >> CC [M] drivers/net/can/c_can/c_can.o
> >> In file included from linux/include/linux/netdevice.h:38:0,
> >> from linux/drivers/net/can/c_can/c_can.c:32:
> >> linux/include/linux/dmaengine.h:55:2: error: expected identifier before numeric constant
> >> linux/include/linux/dmaengine.h: In function 'dma_async_is_complete':
> >> linux/include/linux/dmaengine.h:1023:9: error: 'DMA_IN_PROGRESS' undeclared (first use in this function)
> >> linux/include/linux/dmaengine.h:1023:9: note: each undeclared identifier is reported only once for each function it appears in
> >
> > There are two locations where DMA_COMPLETE is defined:
> >
> >> arch/blackfin/mach-bf548/include/mach/defBF547.h:602:#define DMA_COMPLETE 0x8 /* DMA Complete */
> >> arch/blackfin/mach-bf548/include/mach/defBF544.h:622:#define DMA_COMPLETE 0x8 /* DMA Complete */
> >
> > and
> >
> >> include/linux/dmaengine.h-enum dma_status {
> >> include/linux/dmaengine.h: DMA_COMPLETE,
> >> include/linux/dmaengine.h- DMA_IN_PROGRESS,
> >> include/linux/dmaengine.h- DMA_PAUSED,
> >> include/linux/dmaengine.h- DMA_ERROR,
> >> include/linux/dmaengine.h-};
> >
> > What's the appropriate fix for the problem?
>
> arch/blackfin/mach-bf548/ needs a less generic name for its macro.
Not just these, but looking at the whole file, it needs fix. Names are very
generic here :( and bound to keep colliding with core stuff
--
~Vinod
>
> > Marc
> >
> > [1] Yes, c_can isn't a blackfin driver, but it's the first one in my
> > compile tests and it fails.
> >
>
>
> --
> ~Randy
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
prev parent reply other threads:[~2014-01-13 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 18:09 blackfin + dmaengine: conflicting define/enum "DMA_COMPLETE" Marc Kleine-Budde
2014-01-11 18:31 ` Randy Dunlap
2014-01-11 18:55 ` Marc Kleine-Budde
2014-01-18 7:02 ` Mike Frysinger
2014-02-27 15:59 ` Oleksandr G Zhadan
2014-03-11 10:25 ` Vinod Koul
2014-03-11 14:48 ` Oleksandr G Zhadan
2014-01-13 8:09 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113080907.GB25466@intel.com \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox