From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Borg <cyborg101010@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, abbotti@mev.co.uk,
Levente Kurusa <levex@linux.com>
Subject: Re: [PATCH] AlarmDev: Changing is_wakeup() to be a function to pass checkpatch
Date: Mon, 13 Jan 2014 23:32:04 +0300 [thread overview]
Message-ID: <20140113203204.GG7444@mwanda> (raw)
In-Reply-To: <1389643836-6170-1-git-send-email-cyborg101010@gmail.com>
On Mon, Jan 13, 2014 at 08:10:36PM +0000, Joe Borg wrote:
> Signed-off-by Joe Borg <cyborg101010@gmail.com>
> ---
> drivers/staging/android/alarm-dev.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
> index 647694f..87f2a02 100644
> --- a/drivers/staging/android/alarm-dev.c
> +++ b/drivers/staging/android/alarm-dev.c
> @@ -66,13 +66,15 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
> *
> * Return: 1 if this is a wakeup alarm, otherwise 0
> */
> -static int is_wakeup(enum android_alarm_type type)
> +static int is_wakeup(enum andriod_alarm_type type)
Levente already pointed out that this breaks the build. Really
Levente said was spot on and still applies to the v2 of the patch.
regards,
dan carpenter
next prev parent reply other threads:[~2014-01-13 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 20:10 [PATCH] AlarmDev: Changing is_wakeup() to be a function to pass checkpatch Joe Borg
2014-01-13 20:32 ` Dan Carpenter [this message]
2014-01-13 21:10 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-01-12 14:14 Joe
2014-01-12 15:33 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113203204.GG7444@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=cyborg101010@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox