[PATCH] DAS1800: Fixing foo * bar should be foo *bar

[PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Joe Borg]

Signed-off-by Joe Borg <cyborg101010@gmail.com>
---
 drivers/staging/comedi/drivers/das1800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index 1880038..8fb87df 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
 	return sample;
 }
 
-static void munge_data(struct comedi_device *dev, uint16_t * array,
+static void munge_data(struct comedi_device *dev, uint16_t *array,
 		       unsigned int num_elements)
 {
 	unsigned int i;
-- 
1.8.5.2

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Greg KH]

On Mon, Jan 13, 2014 at 08:14:46PM +0000, Joe Borg wrote:
> Signed-off-by Joe Borg <cyborg101010@gmail.com>

You need a changelog comment here, please.

And is that your "real" email address and name?

greg k-h

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Greg KH]

On Mon, Jan 13, 2014 at 09:23:11PM +0000, Joe Borġ wrote:
> Ok, will do the change log.
> 
> Yes, it's my real name and email... I know the email address is embarrassing,
> but genuine :).
> 
> 
> 
> Regards,
> Joseph David Borġ

There's nothing wrong with using "Joe Borġ" as your signed-off-by: line,
as that's your real name :)

thanks,

greg k-h

[PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Joe Borg]

Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo
*bar' in the parameters of function munge_data().

Signed-off-by Joe Borg <cyborg101010@gmail.com>
---
 drivers/staging/comedi/drivers/das1800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index 1880038..8fb87df 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
 	return sample;
 }
 
-static void munge_data(struct comedi_device *dev, uint16_t * array,
+static void munge_data(struct comedi_device *dev, uint16_t *array,
 		       unsigned int num_elements)
 {
 	unsigned int i;
-- 
1.8.5.2

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Greg KH]

On Mon, Jan 13, 2014 at 11:19:15PM +0000, Joe Borg wrote:
> Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo
> *bar' in the parameters of function munge_data().

Ok, real minor nits here, but I'd like you to make them for future
patches as it makes my life easier, and I don't like to edit patches by
hand, as I don't scale very well.

Your subject should be:
	[PATCH] staging: comedi: das1800: fix for * bar to be foo *bar

you need to add the driver subsystem, and specific area and driver.  And
no kernel drivers are ALL CAPS, so that should never be used.

I've taken this patch as-is, but in the future please try to do this.

Oh, one more thing:

> Signed-off-by Joe Borg <cyborg101010@gmail.com>

You forgot a ':' here :)

thanks,

greg k-h

[PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Joe Borg]

Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data().

Signed-off-by Joe Borg <cyborg101010@gmail.com>
---
 drivers/staging/comedi/drivers/das1800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index 1880038..8fb87df 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
 	return sample;
 }
 
-static void munge_data(struct comedi_device *dev, uint16_t * array,
+static void munge_data(struct comedi_device *dev, uint16_t *array,
 		       unsigned int num_elements)
 {
 	unsigned int i;
-- 
1.8.5.2

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Greg KH]

On Mon, Jan 13, 2014 at 09:47:59PM +0000, Joe Borg wrote:
> Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data().

Please wrap your changelog comments at 72 colums, like git asks you to
when you type them in.

> Signed-off-by Joe Borg <cyborg101010@gmail.com>

No "ġ"?

[PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Joe Borg]

---
 drivers/staging/comedi/drivers/das1800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index 1880038..8fb87df 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
 	return sample;
 }
 
-static void munge_data(struct comedi_device *dev, uint16_t * array,
+static void munge_data(struct comedi_device *dev, uint16_t *array,
 		       unsigned int num_elements)
 {
 	unsigned int i;
-- 
1.8.5.2.309.ga25014b

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Dan Carpenter]

No signed-off line.  Just merge both patches since they do the same
thing and go to the same maintainers.

regards,
dan carpenter

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Dan Carpenter]

On Mon, Jan 13, 2014 at 09:02:33AM +0000, Joe Borġ wrote:
> Apologies for missing that.
> 
> Feel free to add signed-off-by Joe Borg <cyborg101010@gmail.com> to the
> commit message.
> 

Unless it's a bugfix for a security issue then we don't fix other
people's patches.  You have to resend.

regards,
dan carpenter