From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Borg <cyborg101010@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar
Date: Mon, 13 Jan 2014 15:50:42 -0800 [thread overview]
Message-ID: <20140113235042.GA22328@kroah.com> (raw)
In-Reply-To: <1389655155-20071-1-git-send-email-cyborg101010@gmail.com>
On Mon, Jan 13, 2014 at 11:19:15PM +0000, Joe Borg wrote:
> Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo
> *bar' in the parameters of function munge_data().
Ok, real minor nits here, but I'd like you to make them for future
patches as it makes my life easier, and I don't like to edit patches by
hand, as I don't scale very well.
Your subject should be:
[PATCH] staging: comedi: das1800: fix for * bar to be foo *bar
you need to add the driver subsystem, and specific area and driver. And
no kernel drivers are ALL CAPS, so that should never be used.
I've taken this patch as-is, but in the future please try to do this.
Oh, one more thing:
> Signed-off-by Joe Borg <cyborg101010@gmail.com>
You forgot a ':' here :)
thanks,
greg k-h
next prev parent reply other threads:[~2014-01-13 23:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 23:19 [PATCH] DAS1800: Fixing foo * bar should be foo *bar Joe Borg
2014-01-13 23:50 ` Greg KH [this message]
2014-01-13 23:52 ` [PATCH] staging: comedi: das1800: " Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-01-13 21:47 [PATCH] DAS1800: " Joe Borg
2014-01-13 21:53 ` Greg KH
2014-01-13 20:14 Joe Borg
2014-01-13 21:09 ` Greg KH
[not found] ` <CAFFYk1VNGfR_gv81zY4Bvu4J4czN6u9hdeYQZm57jOkZ_TPbng@mail.gmail.com>
2014-01-13 21:34 ` Greg KH
2014-01-11 14:48 Joe Borg
2014-01-13 8:19 ` Dan Carpenter
[not found] ` <CAFFYk1U6o9WYnkQ4nTC7As7c8sDrko54ncDgkeEufy7MeOCdHQ@mail.gmail.com>
2014-01-13 9:17 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113235042.GA22328@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=cyborg101010@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox