[PATCH] DAS1800: Fixing foo * bar should be foo *bar

[PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Joe Borg]

Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo
*bar' in the parameters of function munge_data().

Signed-off-by Joe Borg <cyborg101010@gmail.com>
---
 drivers/staging/comedi/drivers/das1800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index 1880038..8fb87df 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
 	return sample;
 }
 
-static void munge_data(struct comedi_device *dev, uint16_t * array,
+static void munge_data(struct comedi_device *dev, uint16_t *array,
 		       unsigned int num_elements)
 {
 	unsigned int i;
-- 
1.8.5.2

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Greg KH]

On Mon, Jan 13, 2014 at 11:19:15PM +0000, Joe Borg wrote:
> Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo
> *bar' in the parameters of function munge_data().

Ok, real minor nits here, but I'd like you to make them for future
patches as it makes my life easier, and I don't like to edit patches by
hand, as I don't scale very well.

Your subject should be:
	[PATCH] staging: comedi: das1800: fix for * bar to be foo *bar

you need to add the driver subsystem, and specific area and driver.  And
no kernel drivers are ALL CAPS, so that should never be used.

I've taken this patch as-is, but in the future please try to do this.

Oh, one more thing:

> Signed-off-by Joe Borg <cyborg101010@gmail.com>

You forgot a ':' here :)

thanks,

greg k-h

Re: [PATCH] staging: comedi: das1800: Fixing foo * bar should be foo *bar

[Greg KH]

On Mon, Jan 13, 2014 at 11:19:15PM +0000, Joe Borg wrote:
> Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo
> *bar' in the parameters of function munge_data().
> 
> Signed-off-by: Joe Borg <cyborg101010@gmail.com>
> ---
>  drivers/staging/comedi/drivers/das1800.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
> index 1880038..8fb87df 100644
> --- a/drivers/staging/comedi/drivers/das1800.c
> +++ b/drivers/staging/comedi/drivers/das1800.c
> @@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
>  	return sample;
>  }
>  
> -static void munge_data(struct comedi_device *dev, uint16_t * array,
> +static void munge_data(struct comedi_device *dev, uint16_t *array,
>  		       unsigned int num_elements)

Ok, after all that work, it turns out I can't even apply this patch as
someone else did it already a while ago.  You should be working off of
linux-next, or my staging.git tree, not Linus's tree, as that does not
contain all of the work we are doing on the next version of linux (hence
the -next).

So, care to try again with a different fix?

thanks,

greg k-h