public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chase Southwood <chase.southwood@yahoo.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: remove unnecessary braces in pcl711.c
Date: Tue, 14 Jan 2014 10:14:25 +0300	[thread overview]
Message-ID: <20140114071424.GK7444@mwanda> (raw)
In-Reply-To: <1389669196-15041-1-git-send-email-chase.southwood@yahoo.com>

On Mon, Jan 13, 2014 at 09:13:16PM -0600, Chase Southwood wrote:
> This patch for pcl711.c removes braces causing a checkpatch.pl warning.
> It also removes an empty else arm of an if-else statement.
> 
> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
> ---
> 
> I removed the "else" arm of this statement because it was empty, save
> for the "ignore" comment.  If it is instead preferred kernel style for
> this empty else to remain in, let me know and I will correct this
> patch accordingly.
> 

Nope, it's perfect.  Don't doubt yourself.  Always feel free to change
the code.

regards,
dan carpenter


  reply	other threads:[~2014-01-14  7:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14  3:13 [PATCH] Staging: comedi: remove unnecessary braces in pcl711.c Chase Southwood
2014-01-14  7:14 ` Dan Carpenter [this message]
2014-01-14 11:50 ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140114071424.GK7444@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=abbotti@mev.co.uk \
    --cc=chase.southwood@yahoo.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox