From: Mark Brown <broonie@kernel.org>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: lgirdwood@gmail.com, Xiubo Li <Li.Xiubo@freescale.com>,
alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: simple-card: simplify code
Date: Tue, 14 Jan 2014 14:20:14 +0000 [thread overview]
Message-ID: <20140114142014.GM15567@sirena.org.uk> (raw)
In-Reply-To: <20140114123606.2241d8ab@armhf>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Tue, Jan 14, 2014 at 12:36:06PM +0100, Jean-Francois Moine wrote:
> This patch
> - removes the fields of the platform data which are of no use to the
> non-DT platform callers,
> - uses a new private structure to handle all the sound card information,
> - simplifies the code and make easier a possible multi-DAI links extension.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
> Xiubo, I also removed 'of_device_is_available' which seems really
> useless: the module is not probed when the DT status is not "okay".
Please send this as a patch series to aid review, one patch doing four
different changes is much harder to review.
> ret = asoc_simple_card_sub_parse_of(np,
> - &info->cpu_dai,
> - of_cpu);
> + &priv->cpu_dai,
> + (struct device_node **)
> + &dai_link->cpu_of_node,
> + &dai_link->cpu_dai_name);
What's this cast here for? That code doesn't look at all safe.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-14 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 11:36 [PATCH] ASoC: simple-card: simplify code Jean-Francois Moine
2014-01-14 14:20 ` Mark Brown [this message]
2014-01-14 16:12 ` Jean-Francois Moine
2014-01-14 18:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114142014.GM15567@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox