From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@infradead.org, namhyung@kernel.org, mingo@kernel.org,
dsahern@gmail.com, fweisbec@gmail.com, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/6] perf, tools: Support handling complete branch stacks as histograms v3
Date: Wed, 15 Jan 2014 16:27:29 +0100 [thread overview]
Message-ID: <20140115152729.GP20765@two.firstfloor.org> (raw)
In-Reply-To: <20140115144842.GA17358@krava.redhat.com>
> this option is not added in this patch, I tried:
> $ perf report --call-graph=fractal,0.5,callee,function,branch
Of course not, it's in the next patch.
But I was not putting the cumbersome long command line into this
example.
If you really feel strongly about it I guess the two patches could be merged,
but seems cleaner separated.
>
> but as I already said in reply for patch 3, it's not working
> please update the doc in Documentation/perf-report.txt with an example
What kind of example? Full output for a command?
I don't think any other option has that in the man page. It would be
unique.
Having a illustrated `perf tutorial' with examples would probably be a
good idea, but I'm not sure the man page is the right place for that.
-Andi
next prev parent reply other threads:[~2014-01-15 15:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 1:04 Implement lbr-as-callgraph v3 Andi Kleen
2014-01-14 1:04 ` [PATCH 1/6] perf, tools: fix BFD detection on opensuse Andi Kleen
2014-01-14 1:04 ` [PATCH 2/6] perf, tools: Support handling complete branch stacks as histograms v3 Andi Kleen
2014-01-15 14:48 ` Jiri Olsa
2014-01-15 15:27 ` Andi Kleen [this message]
2014-01-15 15:45 ` Jiri Olsa
2014-01-15 15:00 ` Jiri Olsa
2014-01-14 1:04 ` [PATCH 3/6] perf, tools: Add --branch-history option to report v2 Andi Kleen
2014-01-15 14:44 ` Jiri Olsa
2014-01-15 15:23 ` Andi Kleen
2014-01-15 15:42 ` Jiri Olsa
2014-01-14 1:04 ` [PATCH 4/6] perf, tools: Enable printing the srcline in the history Andi Kleen
2014-01-15 15:12 ` Jiri Olsa
2014-01-14 1:04 ` [PATCH 5/6] perf, tools: Only print base source file for srcline Andi Kleen
2014-01-14 1:04 ` [PATCH 6/6] perf, tools: Support source line numbers in annotate Andi Kleen
2014-01-15 13:59 ` Implement lbr-as-callgraph v3 Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115152729.GP20765@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).