Re: [PATCH 2/3] perf tools: Spare double comparison of callchain first entry

Namhyung Kim
2014-01-17T07:56:23Z

Hi Arnaldo and Frederic,

On Thu, 16 Jan 2014 17:47:34 -0200, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 16, 2014 at 06:34:58PM +0100, Frederic Weisbecker escreveu:
>> On Thu, Jan 16, 2014 at 10:17:53AM +0900, Namhyung Kim wrote:
>> > I think if the sort key doesn't contain "symbol", unmatch case would be
>> > increased as more various callchains would go into a same entry.
>>
>> You mean -g fractal,0.5,callee,address ?
>>
>> Hmm, actually I haven't seen much difference there.
>
> I guess he will, but will wait for Namhyung's final ack here, ok?

I meant sorting of hist entry like "-s cpu". So as your number said
it's not an issue IMHO. Arnaldo, I'm good with this change please merge
it. :)

Thanks,
Namhyung