From: Vivek Goyal <vgoyal@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
hpa@linux.intel.com, jingbai.ma@hp.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
bp@alien8.de, ebiederm@xmission.com, akpm@linux-foundation.org,
fengguang.wu@intel.com
Subject: Re: [RESEND PATCH v10] x86, apic, kexec, Documentation: Add disable_cpu_apicid kernel parameter
Date: Wed, 15 Jan 2014 12:47:14 -0500 [thread overview]
Message-ID: <20140115174714.GG3180@redhat.com> (raw)
In-Reply-To: <52D6C4B6.8010804@zytor.com>
On Wed, Jan 15, 2014 at 09:26:14AM -0800, H. Peter Anvin wrote:
> On 01/15/2014 09:05 AM, Vivek Goyal wrote:
> >
> > I think this is a reasonable approach to solve the issue. Use a command
> > line to not bring up specific cpu in second kernel which can create
> > problems.
> >
> > Acked-by: Vivek Goyal <vgoyal@redhat.com>
> >
> > hpa, I know you are not excited about this approach. If you made up your
> > mind that this appoarch is not worth pursuing, please do suggest what
> > would you like to see and we can give that a try.
> >
> > We want to solve this problem as on large memory machines saving dump can
> > take lot of time and we want to bring up multiple cpus and speed up
> > compression and save on dump time.
> >
>
> I'm not excited about kdump's reliance on the command line, since it
> seems to be a neverending source of trouble, simply because the command
> line is fundamentally intended as a human interface.
So in general, what are the alternatives? Either we figure out that kernel
is booting as kdump kernel and do things differently. That seems even
worse as what do we want in kdump kernel will change over a period of
time.
Other thing is that pass more information in bootparams. But that does
not seem much different than command line to me.
> However, this
> seems relatively harmless in comparison with everything else and I am
> much happier with saving the ID in the first kernel rather than trying
> to guess if a currently-downed CPU is the BSP.
So looks like you are alright with this patch. Can you please queue it
up in your tree.
Thanks
Vivek
next prev parent reply other threads:[~2014-01-15 17:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 6:44 [RESEND PATCH v10] x86, apic, kexec, Documentation: Add disable_cpu_apicid kernel parameter HATAYAMA Daisuke
2014-01-15 17:05 ` Vivek Goyal
2014-01-15 17:26 ` H. Peter Anvin
2014-01-15 17:47 ` Vivek Goyal [this message]
2014-01-15 17:54 ` H. Peter Anvin
2014-01-15 18:14 ` Vivek Goyal
2014-01-15 18:20 ` H. Peter Anvin
2014-02-10 17:28 ` Petr Tesarik
2014-01-15 17:57 ` [tip:x86/apic] x86, apic, kexec: " tip-bot for HATAYAMA Daisuke
2014-01-15 18:25 ` Ingo Molnar
2014-01-15 21:09 ` [tip:x86/apic] x86, apic: Make disabled_cpu_apicid static read_mostly, fix typos tip-bot for H. Peter Anvin
2014-01-16 4:44 ` HATAYAMA Daisuke
2014-01-16 5:53 ` H. Peter Anvin
2014-01-16 6:20 ` HATAYAMA Daisuke
2014-01-16 6:24 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115174714.GG3180@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=d.hatayama@jp.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jingbai.ma@hp.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox