From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbaAOSOR (ORCPT ); Wed, 15 Jan 2014 13:14:17 -0500 Received: from mail-qc0-f180.google.com ([209.85.216.180]:50439 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbaAOSOQ (ORCPT ); Wed, 15 Jan 2014 13:14:16 -0500 Date: Wed, 15 Jan 2014 15:14:06 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt , Jiri Olsa Cc: Mark Rutland , linux-kernel@vger.kernel.org, Ingo Molnar , Will Deacon Subject: Re: [PATCH 2/3] tools lib traceevent: fix pointer-integer size mismatch Message-ID: <20140115181406.GB9750@ghostprotocols.net> References: <1389782648-4417-1-git-send-email-mark.rutland@arm.com> <1389782648-4417-3-git-send-email-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1389782648-4417-3-git-send-email-mark.rutland@arm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jan 15, 2014 at 10:44:07AM +0000, Mark Rutland escreveu: > The scsi and cfg80211 plugins cast between unsigned long long and > pointers, which is problematic for architectures where unsigned long > long is wider than the native pointer size: > > linux/tools/lib/traceevent/plugin_scsi.c: In function ‘process_scsi_trace_parse_cdb’: > linux/tools/lib/traceevent/plugin_scsi.c:408:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > scsi_trace_parse_cdb(s, (unsigned char *) args[1], args[2]); > > linux/tools/lib/traceevent/plugin_cfg80211.c: In function ‘process___le16_to_cpup’: > linux/tools/lib/traceevent/plugin_cfg80211.c:11:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > uint16_t *val = (uint16_t *) args[0]; > > This patch adds an intermediate cast to unsigned long, silencing the > warning. Steven, Jiri: Acked-by? > Signed-off-by: Mark Rutland > Cc: Jiri Olsa > Cc: Arnaldo Carvalho de Melo > Cc: Ingo Molnar > --- > tools/lib/traceevent/plugin_cfg80211.c | 2 +- > tools/lib/traceevent/plugin_scsi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > I'm not sure about this one as I'm not certain I read all the sites > input values for args could be generated. I'd appreciate if someone more > familiar with traceevent plugins could verify this makes sense. > > Mark. > > diff --git a/tools/lib/traceevent/plugin_cfg80211.c b/tools/lib/traceevent/plugin_cfg80211.c > index dcab8e8..57e9822 100644 > --- a/tools/lib/traceevent/plugin_cfg80211.c > +++ b/tools/lib/traceevent/plugin_cfg80211.c > @@ -8,7 +8,7 @@ static unsigned long long > process___le16_to_cpup(struct trace_seq *s, > unsigned long long *args) > { > - uint16_t *val = (uint16_t *) args[0]; > + uint16_t *val = (uint16_t *) (unsigned long) args[0]; > return val ? (long long) le16toh(*val) : 0; > } > > diff --git a/tools/lib/traceevent/plugin_scsi.c b/tools/lib/traceevent/plugin_scsi.c > index 6fb8e3e..7ef16cc 100644 > --- a/tools/lib/traceevent/plugin_scsi.c > +++ b/tools/lib/traceevent/plugin_scsi.c > @@ -405,7 +405,7 @@ scsi_trace_parse_cdb(struct trace_seq *p, unsigned char *cdb, int len) > unsigned long long process_scsi_trace_parse_cdb(struct trace_seq *s, > unsigned long long *args) > { > - scsi_trace_parse_cdb(s, (unsigned char *) args[1], args[2]); > + scsi_trace_parse_cdb(s, (unsigned char *) (unsigned long) args[1], args[2]); > return 0; > } > > -- > 1.8.1.1