From: Oleg Nesterov <oleg@redhat.com>
To: Will Drewry <wad@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Nicolas Schichan <nschichan@freebox.fr>,
Kees Cook <keescook@chromium.org>,
James Morris <james.l.morris@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
holt@sgi.com, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 2/2] sys, seccomp: add PR_SECCOMP_EXT and SECCOMP_EXT_ACT_TSYNC
Date: Wed, 15 Jan 2014 20:28:16 +0100 [thread overview]
Message-ID: <20140115192816.GA19396@redhat.com> (raw)
In-Reply-To: <20140115190445.GA18166@redhat.com>
On 01/15, Oleg Nesterov wrote:
>
> I think the
> locking is seriously broken in this series.
And imho seccomp_sync_threads() should fail "safely".
IOW, I think it should do while_each_thread() twice. The first
iteration should just check SECCOMP_MODE_FILTER/is_ancestor()
and fail if necessary. The 2nd one should change other threads.
Btw, it seems that is_ancestor() doesn't need the NULL check,
it is not called if SECCOMP_MODE_DISABLED ?
Oleg.
next prev parent reply other threads:[~2014-01-15 19:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 20:30 [PATCH 1/2] seccomp: protect seccomp.filter pointer (w) with the task_lock Will Drewry
2014-01-13 20:30 ` [PATCH 2/2] sys, seccomp: add PR_SECCOMP_EXT and SECCOMP_EXT_ACT_TSYNC Will Drewry
2014-01-13 22:42 ` [PATCH 3/3] Documentation/prctl/seccomp_filter.txt: document extensions Will Drewry
2014-01-13 23:36 ` [PATCH 2/2] sys, seccomp: add PR_SECCOMP_EXT and SECCOMP_EXT_ACT_TSYNC Andy Lutomirski
2014-01-14 18:59 ` Will Drewry
2014-01-14 20:24 ` Andy Lutomirski
2014-01-14 20:59 ` Will Drewry
2014-01-14 21:09 ` Andy Lutomirski
2014-01-14 21:19 ` Will Drewry
2014-01-14 19:07 ` Oleg Nesterov
2014-01-14 19:21 ` Oleg Nesterov
2014-01-14 20:02 ` Oleg Nesterov
2014-01-14 20:13 ` Oleg Nesterov
2014-01-14 20:53 ` Will Drewry
2014-01-14 21:06 ` Will Drewry
2014-01-15 19:04 ` Oleg Nesterov
2014-01-15 19:28 ` Oleg Nesterov [this message]
2014-01-15 19:33 ` Will Drewry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115192816.GA19396@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=holt@sgi.com \
--cc=james.l.morris@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nschichan@freebox.fr \
--cc=viro@zeniv.linux.org.uk \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox