From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606AbaAPCXm (ORCPT ); Wed, 15 Jan 2014 21:23:42 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]:48112 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbaAPCXk (ORCPT ); Wed, 15 Jan 2014 21:23:40 -0500 Date: Wed, 15 Jan 2014 18:23:32 -0800 From: "Paul E. McKenney" To: Oleg Nesterov Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu Subject: Re: [PATCH tip/core/timers 3/4] timers: Reduce future __run_timers() latency for newly emptied list Message-ID: <20140116022332.GQ10038@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20140115051939.GA31164@linux.vnet.ibm.com> <1389763248-31297-1-git-send-email-paulmck@linux.vnet.ibm.com> <1389763248-31297-3-git-send-email-paulmck@linux.vnet.ibm.com> <20140115170835.GC11499@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140115170835.GC11499@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14011602-3532-0000-0000-000004C77DE2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2014 at 06:08:35PM +0100, Oleg Nesterov wrote: > On 01/14, Paul E. McKenney wrote: > > > > @@ -700,6 +700,7 @@ static int detach_if_pending(struct timer_list *timer, struct tvec_base *base, > > base->next_timer = base->timer_jiffies; > > } > > base->all_timers--; > > + (void)catchup_timer_jiffies(base); > > Agreed, but I think that detach_expired_timer() should do the same, > this can stop main loop in __run_timers(). Good point, added to detach_expired_timer(). Thanx, Paul